Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1912493004: Ship ImageBitmapOptions (Closed)

Created:
4 years, 8 months ago by xidachen
Modified:
4 years, 8 months ago
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ship ImageBitmapOptions We have 3 LGTMs, Let's ship it. BUG=249382, 249384 Committed: https://crrev.com/a78aa93b323af705213d3fee353fb381b972bd9e Cr-Commit-Position: refs/heads/master@{#388877}

Patch Set 1 #

Patch Set 2 : clean up code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -28 lines) Patch
M third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp View 1 2 chunks +2 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.idl View 1 1 chunk +4 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/imagebitmap/ImageBitmapOptions.idl View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
xidachen
PTAL
4 years, 8 months ago (2016-04-21 16:19:30 UTC) #3
Rick Byers
LGTM
4 years, 8 months ago (2016-04-21 16:44:11 UTC) #4
Justin Novosad
lgtm
4 years, 8 months ago (2016-04-21 19:25:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1912493004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1912493004/20001
4 years, 8 months ago (2016-04-21 19:26:24 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-21 20:31:08 UTC) #9
Stephen White
\o/
4 years, 8 months ago (2016-04-21 22:07:28 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:38:40 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/a78aa93b323af705213d3fee353fb381b972bd9e
Cr-Commit-Position: refs/heads/master@{#388877}

Powered by Google App Engine
This is Rietveld 408576698