Video Player: Stop using Cast API shared module.

ui/file_manager/video_player/js/cast/caster.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This hack prevents a bug on the cast extension.
 // TODO(yoshiki): Remove this once the cast extension supports Chrome apps.
 // Although localStorage in Chrome app is not supported, but it's used in the
 // cast extension. This line prevents an exception on using localStorage.
 Object.defineProperty(window, 'localStorage', {
   get: function() { return {}; }
@@ skipping 15 matching lines @@
 function initialize() {
   if (window.loadMockCastExtensionForTest) {
     // If the test flag is set, the mock extension for test will be laoded by
     // the test script. Sets the handler to wait for loading.
     onLoadCastExtension(initializeApi);
     return;
   }
 
   CastExtensionDiscoverer.findInstalledExtension(function(foundId) {
     if (foundId) {
-      loadCastAPI(initializeApi);
+      loadCastAPI(foundId, initializeApi);
     } else {
       console.info('No Google Cast extension is installed.');
 
       metrics.recordCastAPIExtensionStatus(

[yoshiki, 2016/04/26 03:02:52]

I think This metrics should no longer be necessary, since the cast api extension
has been gone.

[fukino, 2016/04/26 03:59:07]

Done. (Removed)

           metrics.CAST_API_EXTENSION_STATUS.SKIPPED);
     }
   }.wrap());
 }
 
 /**
- * Loads the cast API extention. If not install, the extension is installed
- * in background before load. The cast API will load the cast SDK automatically.
- * The given callback is executes after the cast SDK extension is initialized.
+ * Loads the cast API extention.
+ * The cast API will load the cast SDK automatically. The given callback is

[yoshiki, 2016/04/26 03:02:52]

nit: update the  comment.

[fukino, 2016/04/26 03:59:07]

Done.

+ * executes after the cast SDK extension is initialized.
  *
+ * @param {string} extensionId ID of the extension to be loaded.
  * @param {function()} callback Callback (executed asynchronously).
- * @param {boolean=} opt_secondTry Specify true if it's the second call after
- *     installation of Cast API extension.
  */
-function loadCastAPI(callback, opt_secondTry) {
+function loadCastAPI(extensionId, callback) {

[yoshiki, 2016/04/26 03:02:52]

Please rename this, since now this loads the google cast extension, not the
google cast "API" extension.

[fukino, 2016/04/26 03:59:08]

Done.
I renamed it to loadCastSDK(), as it loads Google Cast SDK from the given Cast
extension.

   var script = document.createElement('script');
 
   var onError = function() {
     script.removeEventListener('error', onError);
     document.body.removeChild(script);
 
-    if (opt_secondTry) {
-      metrics.recordCastAPIExtensionStatus(
-          metrics.CAST_API_EXTENSION_STATUS.LOAD_FAILED);
+    metrics.recordCastAPIExtensionStatus(
+        metrics.CAST_API_EXTENSION_STATUS.LOAD_FAILED);
 
-      // Shows error message and exits if it's the 2nd try.
-      console.error('Google Cast API extension load failed.');
-      return;
-    }
-
-    // Installs the Google Cast API extension and retry loading.
-    chrome.webstoreWidgetPrivate.installWebstoreItem(
-        'mafeflapfdfljijmlienjedomfjfmhpd',
-        true,  // Don't use installation prompt.
-        function() {
-          if (chrome.runtime.lastError) {
-            metrics.recordCastAPIExtensionStatus(
-                metrics.CAST_API_EXTENSION_STATUS.INSTALLATION_FAILED);
-
-            console.error('Google Cast API extension installation error.',
-                          chrome.runtime.lastError.message);
-            return;
-          }
-
-          console.info('Google Cast API extension installed.');
-
-          // Loads API again.
-          setTimeout(loadCastAPI.bind(null, callback, true), 0);
-        }.wrap());
-  }.wrap();
+    // Shows error message and exits if it's the 2nd try.

[yoshiki, 2016/04/26 03:02:52]

nit: please update the comment.

[fukino, 2016/04/26 03:59:07]

Removed this comment.

+    console.error('Google Cast API extension load failed.');
+  }

[yoshiki, 2016/04/26 03:02:52]

nit: need .wrap() for consistency?

[yoshiki, 2016/04/26 03:02:52]

nit: semicolon.

[fukino, 2016/04/26 03:59:07]

Done.

[fukino, 2016/04/26 03:59:07]

Done.

 
   // Trys to load the cast API extention which is defined in manifest.json.

[yoshiki, 2016/04/26 03:02:52]

nit: please fix the comment

[fukino, 2016/04/26 03:59:07]

Done.

-  script.src = '_modules/mafeflapfdfljijmlienjedomfjfmhpd/cast_sender.js';
+  window.chrome['cast'] = window.chrome['cast'] || {};
+  window.chrome['cast']['extensionId'] = extensionId;
+  script.src = 'chrome-extension://' + extensionId + '/cast_sender.js';
   script.addEventListener('error', onError);
   script.addEventListener(
-      'load', onLoadCastExtension.bind(null, callback, opt_secondTry));
+      'load', onLoadCastExtension.bind(null, callback));
   document.body.appendChild(script);
 }
 
 /**
  * Loads the cast sdk extension.
  * @param {function()} callback Callback (executed asynchronously).
- * @param {boolean=} opt_installationOccured True if the extension is just
- *     installed in this window. False or null if it's already installed.
  */
-function onLoadCastExtension(callback, opt_installationOccured) {
+function onLoadCastExtension(callback) {
   var executeCallback = function() {
-    if (opt_installationOccured) {
-      metrics.recordCastAPIExtensionStatus(
-          metrics.CAST_API_EXTENSION_STATUS.INSTALLED_AND_LOADED);
-    } else {
-      metrics.recordCastAPIExtensionStatus(
-          metrics.CAST_API_EXTENSION_STATUS.LOADED);
-    }
+    metrics.recordCastAPIExtensionStatus(
+        metrics.CAST_API_EXTENSION_STATUS.LOADED);
 
     setTimeout(callback, 0);  // Runs asynchronously.
   };
 
   if(!chrome.cast || !chrome.cast.isAvailable) {
     var checkTimer = setTimeout(function() {
       console.error('Either "Google Cast API" or "Google Cast" extension ' +
                     'seems not to be installed?');
 
       metrics.recordCastAPIExtensionStatus(
@@ skipping 61 matching lines @@
     metrics.recordNumberOfCastDevices(receivers.length);
     player.setCastList(receivers);
   } else if (availability == chrome.cast.ReceiverAvailability.UNAVAILABLE) {
     metrics.recordNumberOfCastDevices(0);
     player.setCastList([]);
   } else {
     console.error('Unexpected response in onReceiver.', arguments);
     player.setCastList([]);
   }
 }