Video Player: Stop using Cast API shared module.

Video Player: Stop using Cast API shared module.

As the shared module will not be supported anymore and it doesn't handle media router.
We should use Cast Extension's cast_sender.js instead.

BUG=605391
TEST=make sure that the madia router is disabled, a Google Cast extension is
installed, there is at least one available cast device, and check that we can
cast video on Google Drive from built-in video player.

Committed: https://crrev.com/24bc75500304280de2a4cdfbe0f6eb4c81d1e679
Cr-Commit-Position: refs/heads/master@{#389738}

[fukino, 2016-04-21 04:10:31]

fukino@chromium.org changed reviewers:
+ yoshiki@chromium.org

[fukino, 2016-04-21 04:10:32]

PTAL. Thanks!

[fukino, 2016-04-25 03:27:06]

ping.

[yoshiki, 2016-04-26 03:02:52]

Sorry for delay.

https://codereview.chromium.org/1912493003/diff/1/ui/file_manager/video_playe...
File ui/file_manager/video_player/js/cast/caster.js (right):

https://codereview.chromium.org/1912493003/diff/1/ui/file_manager/video_playe...
ui/file_manager/video_player/js/cast/caster.js:40:
metrics.recordCastAPIExtensionStatus(
I think This metrics should no longer be necessary, since the cast api extension
has been gone.

https://codereview.chromium.org/1912493003/diff/1/ui/file_manager/video_playe...
ui/file_manager/video_player/js/cast/caster.js:48: * The cast API will load the
cast SDK automatically. The given callback is
nit: update the  comment.

https://codereview.chromium.org/1912493003/diff/1/ui/file_manager/video_playe...
ui/file_manager/video_player/js/cast/caster.js:54: function
loadCastAPI(extensionId, callback) {
Please rename this, since now this loads the google cast extension, not the
google cast "API" extension.

https://codereview.chromium.org/1912493003/diff/1/ui/file_manager/video_playe...
ui/file_manager/video_player/js/cast/caster.js:64: // Shows error message and
exits if it's the 2nd try.
nit: please update the comment.

https://codereview.chromium.org/1912493003/diff/1/ui/file_manager/video_playe...
ui/file_manager/video_player/js/cast/caster.js:66: }
nit: semicolon.

https://codereview.chromium.org/1912493003/diff/1/ui/file_manager/video_playe...
ui/file_manager/video_player/js/cast/caster.js:66: }
nit: need .wrap() for consistency?

https://codereview.chromium.org/1912493003/diff/1/ui/file_manager/video_playe...
ui/file_manager/video_player/js/cast/caster.js:68: // Trys to load the cast API
extention which is defined in manifest.json.
nit: please fix the comment

[fukino, 2016-04-26 03:59:08]

Thank you!

https://codereview.chromium.org/1912493003/diff/1/ui/file_manager/video_playe...
File ui/file_manager/video_player/js/cast/caster.js (right):

https://codereview.chromium.org/1912493003/diff/1/ui/file_manager/video_playe...
ui/file_manager/video_player/js/cast/caster.js:40:
metrics.recordCastAPIExtensionStatus(
On 2016/04/26 03:02:52, yoshiki wrote:
> I think This metrics should no longer be necessary, since the cast api
extension
> has been gone.

Done. (Removed)

https://codereview.chromium.org/1912493003/diff/1/ui/file_manager/video_playe...
ui/file_manager/video_player/js/cast/caster.js:48: * The cast API will load the
cast SDK automatically. The given callback is
On 2016/04/26 03:02:52, yoshiki wrote:
> nit: update the  comment.

Done.

https://codereview.chromium.org/1912493003/diff/1/ui/file_manager/video_playe...
ui/file_manager/video_player/js/cast/caster.js:54: function
loadCastAPI(extensionId, callback) {
On 2016/04/26 03:02:52, yoshiki wrote:
> Please rename this, since now this loads the google cast extension, not the
> google cast "API" extension.

Done.
I renamed it to loadCastSDK(), as it loads Google Cast SDK from the given Cast
extension.

https://codereview.chromium.org/1912493003/diff/1/ui/file_manager/video_playe...
ui/file_manager/video_player/js/cast/caster.js:64: // Shows error message and
exits if it's the 2nd try.
On 2016/04/26 03:02:52, yoshiki wrote:
> nit: please update the comment.

Removed this comment.

https://codereview.chromium.org/1912493003/diff/1/ui/file_manager/video_playe...
ui/file_manager/video_player/js/cast/caster.js:66: }
On 2016/04/26 03:02:52, yoshiki wrote:
> nit: need .wrap() for consistency?

Done.

https://codereview.chromium.org/1912493003/diff/1/ui/file_manager/video_playe...
ui/file_manager/video_player/js/cast/caster.js:66: }
On 2016/04/26 03:02:52, yoshiki wrote:
> nit: semicolon.

Done.

https://codereview.chromium.org/1912493003/diff/1/ui/file_manager/video_playe...
ui/file_manager/video_player/js/cast/caster.js:68: // Trys to load the cast API
extention which is defined in manifest.json.
On 2016/04/26 03:02:52, yoshiki wrote:
> nit: please fix the comment

Done.

[yoshiki, 2016-04-26 05:01:16]

https://codereview.chromium.org/1912493003/diff/20001/ui/file_manager/video_p...
File ui/file_manager/video_player/js/cast/caster.js (right):

https://codereview.chromium.org/1912493003/diff/20001/ui/file_manager/video_p...
ui/file_manager/video_player/js/cast/caster.js:57:
metrics.recordCastAPIExtensionStatus(
Please remove this as well. I think we can remove the entire of this metrics.

https://codereview.chromium.org/1912493003/diff/20001/ui/file_manager/video_p...
ui/file_manager/video_player/js/cast/caster.js:68: script.addEventListener(
nit: no need for new line?

https://codereview.chromium.org/1912493003/diff/20001/ui/file_manager/video_p...
ui/file_manager/video_player/js/cast/caster.js:80:
metrics.recordCastAPIExtensionStatus(
ditto

https://codereview.chromium.org/1912493003/diff/20001/ui/file_manager/video_p...
File ui/file_manager/video_player/manifest.json (right):

https://codereview.chromium.org/1912493003/diff/20001/ui/file_manager/video_p...
ui/file_manager/video_player/manifest.json:31: "webstoreWidgetPrivate",
nit: we may be able to remove this.

[yoshiki, 2016-04-26 05:04:31]

https://codereview.chromium.org/1912493003/diff/20001/ui/file_manager/video_p...
File ui/file_manager/video_player/js/cast/caster.js (right):

https://codereview.chromium.org/1912493003/diff/20001/ui/file_manager/video_p...
ui/file_manager/video_player/js/cast/caster.js:65:
window.chrome['cast']['extensionId'] = extensionId;
I can't file the usage of this? Is this necessary? Please add the comment if it
is depended externally.

[fukino, 2016-04-26 06:36:18]

Thanks! Some more lines are deleted :)

https://codereview.chromium.org/1912493003/diff/20001/ui/file_manager/video_p...
File ui/file_manager/video_player/js/cast/caster.js (right):

https://codereview.chromium.org/1912493003/diff/20001/ui/file_manager/video_p...
ui/file_manager/video_player/js/cast/caster.js:57:
metrics.recordCastAPIExtensionStatus(
On 2016/04/26 05:01:16, yoshiki wrote:
> Please remove this as well. I think we can remove the entire of this metrics.

I removed all the metrics about CAST_API_EXTENSION_STATUS and
metrics.recordCastAPIExtensionStatus.

https://codereview.chromium.org/1912493003/diff/20001/ui/file_manager/video_p...
ui/file_manager/video_player/js/cast/caster.js:65:
window.chrome['cast']['extensionId'] = extensionId;
On 2016/04/26 05:04:30, yoshiki wrote:
> I can't file the usage of this? Is this necessary? Please add the comment if
it
> is depended externally.

Added a comment.
Legacy cast extension relies on the extension ID being set by bootstrap code.
https://cs.corp.google.com/piper///depot/google3/chrome_platform/cast/script/...

https://codereview.chromium.org/1912493003/diff/20001/ui/file_manager/video_p...
ui/file_manager/video_player/js/cast/caster.js:68: script.addEventListener(
On 2016/04/26 05:01:16, yoshiki wrote:
> nit: no need for new line?

Done.

https://codereview.chromium.org/1912493003/diff/20001/ui/file_manager/video_p...
ui/file_manager/video_player/js/cast/caster.js:80:
metrics.recordCastAPIExtensionStatus(
On 2016/04/26 05:01:16, yoshiki wrote:
> ditto

Done.

[yoshiki, 2016-04-26 07:06:57]

LGTM. Please consider to removing the metrics at all from Chrome source
(metrics.txt, etc). But it's fine for me to do it in a separate CL.

https://codereview.chromium.org/1912493003/diff/40001/ui/file_manager/video_p...
File ui/file_manager/video_player/js/cast/caster.js (right):

https://codereview.chromium.org/1912493003/diff/40001/ui/file_manager/video_p...
ui/file_manager/video_player/js/cast/caster.js:56: console.error('Google Cast
API extension load failed.');
nit: Remove "API"

[fukino, 2016-04-26 08:57:30]

Thank you!
Let me do remaining clean-ups in a separate CL.

https://codereview.chromium.org/1912493003/diff/40001/ui/file_manager/video_p...
File ui/file_manager/video_player/js/cast/caster.js (right):

https://codereview.chromium.org/1912493003/diff/40001/ui/file_manager/video_p...
ui/file_manager/video_player/js/cast/caster.js:56: console.error('Google Cast
API extension load failed.');
On 2016/04/26 07:06:57, yoshiki wrote:
> nit: Remove "API"

Done.

[fukino, 2016-04-26 08:57:46]

The CQ bit was checked by fukino@chromium.org

[fukino, 2016-04-26 08:57:46]

The patchset sent to the CQ was uploaded after l-g-t-m from yoshiki@chromium.org
Link to the patchset: https://codereview.chromium.org/1912493003/#ps60001
(title: "Update an error message.")

[commit-bot: I haz the power, 2016-04-26 08:57:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1912493003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1912493003/60001

[commit-bot: I haz the power, 2016-04-26 09:56:00]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-04-26 09:56:44]

Description was changed from

==========
Video Player: Stop using Cast API shared module.

As the shared module will not be supported anymore and it doesn't handle media
router.
We should use Cast Extension's cast_sender.js instead.

BUG=605391
TEST=make sure that the madia router is disabled, a Google Cast extension is
installed, there is at least one available cast device, and check that we can
cast video on Google Drive from built-in video player.
==========

to

==========
Video Player: Stop using Cast API shared module.

As the shared module will not be supported anymore and it doesn't handle media
router.
We should use Cast Extension's cast_sender.js instead.

BUG=605391
TEST=make sure that the madia router is disabled, a Google Cast extension is
installed, there is at least one available cast device, and check that we can
cast video on Google Drive from built-in video player.

Committed: https://crrev.com/24bc75500304280de2a4cdfbe0f6eb4c81d1e679
Cr-Commit-Position: refs/heads/master@{#389738}
==========

[commit-bot: I haz the power, 2016-04-26 09:56:46]

Patchset 4 (id:??) landed as
https://crrev.com/24bc75500304280de2a4cdfbe0f6eb4c81d1e679
Cr-Commit-Position: refs/heads/master@{#389738}