Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 1912483004: [Findit] Add failure type to dashboard. (Closed)

Created:
4 years, 8 months ago by stgao
Modified:
4 years, 8 months ago
CC:
chromium-reviews, infra-reviews+infra_chromium.org, Sharu Jiang
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 5

Patch Set 2 : . #

Total comments: 2

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -1 line) Patch
M appengine/findit/common/waterfall/failure_type.py View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M appengine/findit/handlers/list_analyses.py View 1 chunk +2 lines, -1 line 0 comments Download
M appengine/findit/handlers/test/list_analyses_test.py View 14 chunks +14 lines, -0 lines 0 comments Download
M appengine/findit/model/test/wf_analysis_test.py View 1 chunk +5 lines, -0 lines 0 comments Download
M appengine/findit/model/wf_analysis.py View 1 chunk +4 lines, -0 lines 0 comments Download
M appengine/findit/templates/list_analyses.html View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
stgao
ptal
4 years, 8 months ago (2016-04-21 19:02:29 UTC) #2
lijeffrey1
https://codereview.chromium.org/1912483004/diff/1/appengine/findit/common/waterfall/failure_type.py File appengine/findit/common/waterfall/failure_type.py (right): https://codereview.chromium.org/1912483004/diff/1/appengine/findit/common/waterfall/failure_type.py#newcode18 appengine/findit/common/waterfall/failure_type.py:18: return description.get(failure_type, 'UNKNOWN') Should this default to 'unknown' or ...
4 years, 8 months ago (2016-04-21 19:40:06 UTC) #4
chanli
https://codereview.chromium.org/1912483004/diff/1/appengine/findit/common/waterfall/failure_type.py File appengine/findit/common/waterfall/failure_type.py (right): https://codereview.chromium.org/1912483004/diff/1/appengine/findit/common/waterfall/failure_type.py#newcode18 appengine/findit/common/waterfall/failure_type.py:18: return description.get(failure_type, 'UNKNOWN') On 2016/04/21 19:40:05, lijeffrey1 wrote: > ...
4 years, 8 months ago (2016-04-21 20:10:45 UTC) #5
chanli
On 2016/04/21 20:10:45, chanli wrote: > https://codereview.chromium.org/1912483004/diff/1/appengine/findit/common/waterfall/failure_type.py > File appengine/findit/common/waterfall/failure_type.py (right): > > https://codereview.chromium.org/1912483004/diff/1/appengine/findit/common/waterfall/failure_type.py#newcode18 > ...
4 years, 8 months ago (2016-04-21 20:12:13 UTC) #6
stgao
https://codereview.chromium.org/1912483004/diff/1/appengine/findit/common/waterfall/failure_type.py File appengine/findit/common/waterfall/failure_type.py (right): https://codereview.chromium.org/1912483004/diff/1/appengine/findit/common/waterfall/failure_type.py#newcode18 appengine/findit/common/waterfall/failure_type.py:18: return description.get(failure_type, 'UNKNOWN') On 2016/04/21 20:10:45, chanli wrote: > ...
4 years, 8 months ago (2016-04-21 20:40:47 UTC) #8
lijeffrey
https://codereview.chromium.org/1912483004/diff/1/appengine/findit/common/waterfall/failure_type.py File appengine/findit/common/waterfall/failure_type.py (right): https://codereview.chromium.org/1912483004/diff/1/appengine/findit/common/waterfall/failure_type.py#newcode18 appengine/findit/common/waterfall/failure_type.py:18: return description.get(failure_type, 'UNKNOWN') On 2016/04/21 20:40:47, stgao wrote: > ...
4 years, 8 months ago (2016-04-21 20:50:43 UTC) #9
stgao
https://codereview.chromium.org/1912483004/diff/1/appengine/findit/common/waterfall/failure_type.py File appengine/findit/common/waterfall/failure_type.py (right): https://codereview.chromium.org/1912483004/diff/1/appengine/findit/common/waterfall/failure_type.py#newcode18 appengine/findit/common/waterfall/failure_type.py:18: return description.get(failure_type, 'UNKNOWN') On 2016/04/21 20:50:43, lijeffrey wrote: > ...
4 years, 8 months ago (2016-04-21 22:42:35 UTC) #10
lijeffrey
lgtm with a tiny nit https://codereview.chromium.org/1912483004/diff/20001/appengine/findit/common/waterfall/failure_type.py File appengine/findit/common/waterfall/failure_type.py (right): https://codereview.chromium.org/1912483004/diff/20001/appengine/findit/common/waterfall/failure_type.py#newcode18 appengine/findit/common/waterfall/failure_type.py:18: return description.get(failure_type, 'No Description ...
4 years, 8 months ago (2016-04-21 23:54:10 UTC) #11
stgao
https://codereview.chromium.org/1912483004/diff/20001/appengine/findit/common/waterfall/failure_type.py File appengine/findit/common/waterfall/failure_type.py (right): https://codereview.chromium.org/1912483004/diff/20001/appengine/findit/common/waterfall/failure_type.py#newcode18 appengine/findit/common/waterfall/failure_type.py:18: return description.get(failure_type, 'No Description for %s' % failure_type) On ...
4 years, 8 months ago (2016-04-22 00:02:56 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1912483004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1912483004/40001
4 years, 8 months ago (2016-04-22 00:03:13 UTC) #15
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 00:07:12 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/infra/infra/+/2cf3601bfe1e1f3ad817b25dd8798...

Powered by Google App Engine
This is Rietveld 408576698