Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1912473002: Remove GTM_ENABLE_LEAKS and GTMGarbageCollection (Closed)

Created:
4 years, 8 months ago by dmac
Modified:
4 years, 8 months ago
Reviewers:
Mark Mentovai, ivanpe
CC:
google-breakpad-dev_googlegroups.com
Base URL:
https://chromium.googlesource.com/breakpad/breakpad.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove GTM_ENABLE_LEAKS and GTMGarbageCollection Removes some archaic Google Toolbox For Mac features. BUG= R=ivanpe@chromium.org, mark@chromium.org Committed: https://chromium.googlesource.com/breakpad/breakpad/+/8762c822976531ff0f9705a1be1e62ca0a40cdfb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -74 lines) Patch
M src/client/mac/Breakpad.xcodeproj/project.pbxproj View 2 chunks +0 lines, -2 lines 0 comments Download
M src/common/mac/testing/GTMSenTestCase.m View 2 chunks +0 lines, -72 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
dmac
PTAL
4 years, 8 months ago (2016-04-21 15:24:58 UTC) #4
ivanpe
On 2016/04/21 15:24:58, dmac wrote: > PTAL LGTM
4 years, 8 months ago (2016-04-21 17:59:15 UTC) #5
Mark Mentovai
LGTM
4 years, 8 months ago (2016-04-21 18:02:27 UTC) #6
dmac
4 years, 8 months ago (2016-04-21 20:20:23 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
8762c822976531ff0f9705a1be1e62ca0a40cdfb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698