Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 1912443004: [tests] Add testcase for r35397 (Closed)

Created:
4 years, 8 months ago by Jakob Kummerow
Modified:
4 years, 8 months ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[tests] Add testcase for r35397 This is a follow-up to 58429beb7b030805197c8968bcae4b2c20127804 "Fix KeyedStore stub selection for STRING_WRAPPER_ELEMENTS". BUG=chromium:602184 LOG=n Committed: https://crrev.com/f4a9a50147ebc3498e53391f7a9a478a70786a3c Cr-Commit-Position: refs/heads/master@{#35715}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
A + test/mjsunit/regress/regress-crbug-602184.js View 1 chunk +10 lines, -8 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Jakob Kummerow
PTAL. It seems I forgot to "git add" this the other day ;-)
4 years, 8 months ago (2016-04-21 14:48:39 UTC) #2
Igor Sheludko
lgtm
4 years, 8 months ago (2016-04-21 15:16:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1912443004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1912443004/1
4 years, 8 months ago (2016-04-21 15:42:22 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_nodcheck_rel_ng on tryserver.v8 (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/builds/549)
4 years, 8 months ago (2016-04-21 17:44:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1912443004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1912443004/1
4 years, 8 months ago (2016-04-22 08:44:11 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-22 09:08:23 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:15:08 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f4a9a50147ebc3498e53391f7a9a478a70786a3c
Cr-Commit-Position: refs/heads/master@{#35715}

Powered by Google App Engine
This is Rietveld 408576698