tools/perf/page_sets/key_mobile_sites.py - Issue 1912443002: Reimplement basic PopularUrls page cycler in telemetry.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/page_sets/key_mobile_sites.py

Issue 1912443002: Reimplement basic PopularUrls page cycler in telemetry. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/page_sets/key_mobile_sites.py

diff --git a/tools/perf/page_sets/key_mobile_sites.py b/tools/perf/page_sets/key_mobile_sites.py

index 7d28502e72e8866250492cb9b0d174c07fe1ba68..eb354927191876eb3628960ad1475e7e91b31e59 100644

--- a/tools/perf/page_sets/key_mobile_sites.py

+++ b/tools/perf/page_sets/key_mobile_sites.py

@@ -16,7 +16,6 @@ class KeyMobileSitesPage(page_module.Page):

url=url, page_set=page_set, name=name,

shared_page_state_class=shared_page_state.SharedMobilePageState,

credentials_path='data/credentials.json', labels=labels)

- self.archive_data_file = 'data/key_mobile_sites.json'

jbudorick 2016/04/20 22:32:45 ?

mikecase (-- gone --) 2016/04/28 20:49:52 this is just an unused field. I cleaned a bunch of

self.action_on_load_complete = action_on_load_complete

« no previous file with comments | « tools/perf/benchmarks/page_cycler.py ('k') | tools/perf/page_sets/popular_urls.py » ('j') | no next file with comments »