Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 1912403002: X87: [turbofan] Introduce TruncateTaggedToWord32 simplified operator. (Closed)

Created:
4 years, 8 months ago by zhengxing.li
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [turbofan] Introduce TruncateTaggedToWord32 simplified operator. port 0231a7efa2b5ce8108a837284e2f63dccd5dcd09 (r35743) original commit message: This allows us to get rid of the "push TruncateFloat64ToInt32 into Phi" trick that was used in the MachineOperatorReducer to combine the ChangeTaggedToFloat64 and TruncateFloat64ToInt32 operations. Instead of doing that later, we can just introduce the proper operator during the representation selection directly. Also separate the TruncateFloat64ToInt32 machine operator, which had two different meanings depending on a flag (either JavaScript truncation or C++ style round to zero). Now there's a TruncateFloat64ToWord32 which represents the JavaScript truncation (implemented via TruncateDoubleToI macro + code stub) and the RoundFloat64ToInt32, which implements the C++ round towards zero operation (in the same style as the other WebAssembly driven Round* machine operators). BUG= Committed: https://crrev.com/c631277411a75525c2c6167051a1040552c7dd0e Cr-Commit-Position: refs/heads/master@{#35745}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -11 lines) Patch
M src/compiler/x87/instruction-selector-x87.cc View 1 chunk +6 lines, -11 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 8 months ago (2016-04-25 02:15:32 UTC) #2
Weiliang
lgtm
4 years, 8 months ago (2016-04-25 02:18:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1912403002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1912403002/1
4 years, 8 months ago (2016-04-25 02:32:18 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-25 02:49:19 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-25 02:50:16 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c631277411a75525c2c6167051a1040552c7dd0e
Cr-Commit-Position: refs/heads/master@{#35745}

Powered by Google App Engine
This is Rietveld 408576698