device/nfc/nfc_impl.h - Issue 1912363002: [webnfc] Add default implementation for nfc mojo service.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: device/nfc/nfc_impl.h

Issue 1912363002: [webnfc] Add default implementation for nfc mojo service. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixes for Reilly's comments. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef DEVICE_NFC_NFC_IMPL_H_

	6 #define DEVICE_NFC_NFC_IMPL_H_

	7

	8 #include "device/nfc/nfc.mojom.h"

	9 #include "device/nfc/nfc_export.h"

	10

	11 namespace device {

	12

	13 class NFCImpl {
	ncarter (slow) 2016/04/26 22:28:26 Question for reilly: should we be calling this Nfc Question for reilly: should we be calling this NfcImpl or NFCImpl? There was a chromium-dev thread on this last fall, that suggested we should prefer the lowercase-style acronyms, at least in new code. https://groups.google.com/a/chromium.org/d/msg/chromium-dev/k8-ztIrWaUY/hajvv... Reilly Grant (use Gerrit) 2016/04/26 22:35:33 It should be NfcImpl. Show quoted text On 2016/04/26 at 22:28:26, ncarter wrote: > Question for reilly: should we be calling this NfcImpl or NFCImpl? > > There was a chromium-dev thread on this last fall, that suggested we should prefer the lowercase-style acronyms, at least in new code. https://groups.google.com/a/chromium.org/d/msg/chromium-dev/k8-ztIrWaUY/hajvv... It should be NfcImpl.
	14 public:

	15 DEVICE_NFC_EXPORT static void Create(mojo::InterfaceRequest<NFC> request);

	16 };

	17

	18 } // namespace device

	19

	20 #endif // DEVICE_NFC_NFC_IMPL_H_

OLD	NEW

« content/browser/frame_host/render_frame_host_impl.cc ('K') | « device/nfc/nfc_export.h ('k') | device/nfc/nfc_impl_default.cc » ('j') | no next file with comments »