src/x64/assembler-x64.cc - Issue 191233003: Add out-of-line constant pool support to Arm.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/assembler-x64.cc

Issue 191233003: Add out-of-line constant pool support to Arm. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addresss comments Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x64/assembler-x64.cc

diff --git a/src/x64/assembler-x64.cc b/src/x64/assembler-x64.cc

index 53d45bb2156635647a35224d57069886cc80372f..dd3ab0ca51963ea32f662a2bbd400736b2e29884 100644

--- a/src/x64/assembler-x64.cc

+++ b/src/x64/assembler-x64.cc

@@ -3199,6 +3199,12 @@ void Assembler::RecordComment(const char* msg, bool force) {

}

+void Assembler::PopulateConstantPool(ConstantPoolArray* constant_pool) {

+ // No out-of-line constant pool support.

+ UNREACHABLE();

const int RelocInfo::kApplyMask = RelocInfo::kCodeTargetMask |

1 << RelocInfo::RUNTIME_ENTRY |

1 << RelocInfo::INTERNAL_REFERENCE |