Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1321)

Side by Side Diff: src/x64/assembler-x64.cc

Issue 191233003: Add out-of-line constant pool support to Arm. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addresss comments Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3181 matching lines...) Expand 10 before | Expand all | Expand 10 after
3192 3192
3193 3193
3194 void Assembler::RecordComment(const char* msg, bool force) { 3194 void Assembler::RecordComment(const char* msg, bool force) {
3195 if (FLAG_code_comments || force) { 3195 if (FLAG_code_comments || force) {
3196 EnsureSpace ensure_space(this); 3196 EnsureSpace ensure_space(this);
3197 RecordRelocInfo(RelocInfo::COMMENT, reinterpret_cast<intptr_t>(msg)); 3197 RecordRelocInfo(RelocInfo::COMMENT, reinterpret_cast<intptr_t>(msg));
3198 } 3198 }
3199 } 3199 }
3200 3200
3201 3201
3202 void Assembler::PopulateConstantPool(ConstantPoolArray* constant_pool) {
3203 // No out-of-line constant pool support.
3204 UNREACHABLE();
3205 }
3206
3207
3202 const int RelocInfo::kApplyMask = RelocInfo::kCodeTargetMask | 3208 const int RelocInfo::kApplyMask = RelocInfo::kCodeTargetMask |
3203 1 << RelocInfo::RUNTIME_ENTRY | 3209 1 << RelocInfo::RUNTIME_ENTRY |
3204 1 << RelocInfo::INTERNAL_REFERENCE | 3210 1 << RelocInfo::INTERNAL_REFERENCE |
3205 1 << RelocInfo::CODE_AGE_SEQUENCE; 3211 1 << RelocInfo::CODE_AGE_SEQUENCE;
3206 3212
3207 3213
3208 bool RelocInfo::IsCodedSpecially() { 3214 bool RelocInfo::IsCodedSpecially() {
3209 // The deserializer needs to know whether a pointer is specially coded. Being 3215 // The deserializer needs to know whether a pointer is specially coded. Being
3210 // specially coded on x64 means that it is a relative 32 bit address, as used 3216 // specially coded on x64 means that it is a relative 32 bit address, as used
3211 // by branch instructions. 3217 // by branch instructions.
3212 return (1 << rmode_) & kApplyMask; 3218 return (1 << rmode_) & kApplyMask;
3213 } 3219 }
3214 3220
3215 3221
3216 bool RelocInfo::IsInConstantPool() { 3222 bool RelocInfo::IsInConstantPool() {
3217 return false; 3223 return false;
3218 } 3224 }
3219 3225
3220 3226
3221 } } // namespace v8::internal 3227 } } // namespace v8::internal
3222 3228
3223 #endif // V8_TARGET_ARCH_X64 3229 #endif // V8_TARGET_ARCH_X64
OLDNEW
« src/heap.cc ('K') | « src/x64/assembler-x64.h ('k') | test/cctest/test-reloc-info.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698