Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Side by Side Diff: chrome/browser/platform_util.cc

Issue 1912303002: OpenItem now posts its task with CONTINUE_ON_SHUTDOWN semantic. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fix_delayed_analysis
Patch Set: Rebased Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/platform_util.h" 5 #include "chrome/browser/platform_util.h"
6 6
7 #include "base/files/file.h" 7 #include "base/files/file.h"
8 #include "base/files/file_util.h" 8 #include "base/files/file_util.h"
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "chrome/browser/platform_util_internal.h" 10 #include "chrome/browser/platform_util_internal.h"
11 #include "chrome/common/chrome_features.h"
11 #include "content/public/browser/browser_thread.h" 12 #include "content/public/browser/browser_thread.h"
12 13
13 using content::BrowserThread; 14 using content::BrowserThread;
14 15
15 namespace platform_util { 16 namespace platform_util {
16 17
17 namespace { 18 namespace {
18 19
19 bool shell_operations_allowed = true; 20 bool shell_operations_allowed = true;
20 21
(...skipping 29 matching lines...) Expand all
50 shell_operations_allowed = false; 51 shell_operations_allowed = false;
51 } 52 }
52 53
53 } // namespace internal 54 } // namespace internal
54 55
55 void OpenItem(Profile* profile, 56 void OpenItem(Profile* profile,
56 const base::FilePath& full_path, 57 const base::FilePath& full_path,
57 OpenItemType item_type, 58 OpenItemType item_type,
58 const OpenOperationCallback& callback) { 59 const OpenOperationCallback& callback) {
59 DCHECK_CURRENTLY_ON(BrowserThread::UI); 60 DCHECK_CURRENTLY_ON(BrowserThread::UI);
60 BrowserThread::PostBlockingPoolTask( 61 base::SequencedWorkerPool::WorkerShutdown shutdown_mode =
62 base::FeatureList::IsEnabled(features::kBrowserHangFixesExperiment)
63 ? base::SequencedWorkerPool::CONTINUE_ON_SHUTDOWN
64 : base::SequencedWorkerPool::SKIP_ON_SHUTDOWN;
65 BrowserThread::GetBlockingPool()->PostWorkerTaskWithShutdownBehavior(
61 FROM_HERE, base::Bind(&VerifyAndOpenItemOnBlockingThread, full_path, 66 FROM_HERE, base::Bind(&VerifyAndOpenItemOnBlockingThread, full_path,
62 item_type, callback)); 67 item_type, callback),
68 shutdown_mode);
63 } 69 }
64 70
65 } // namespace platform_util 71 } // namespace platform_util
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698