Chromium Code Reviews| Index: pkg/barback/test/package_graph/group_test.dart |
| diff --git a/pkg/barback/test/package_graph/group_test.dart b/pkg/barback/test/package_graph/group_test.dart |
| index 2588ebfc5570069d6a437de5da6a234aca92228d..c05957d79534295534ed96f2ba35be0581771649 100644 |
| --- a/pkg/barback/test/package_graph/group_test.dart |
| +++ b/pkg/barback/test/package_graph/group_test.dart |
| @@ -191,23 +191,21 @@ main() { |
| buildShouldSucceed(); |
| }); |
| - // TODO(nweiz): re-enable this test when a transformer can consume its |
| - // primary input (issue 16612). |
| - // test("parallel groups' intermediate assets can't collide", () { |
| - // initGraph(["app|foo.a", "app|foo.x"], {"app": [ |
| - // [new TransformerGroup([ |
| - // [new RewriteTransformer("a", "b")], |
| - // [new RewriteTransformer("b", "c")] |
| - // ]), new TransformerGroup([ |
| - // [new RewriteTransformer("x", "b")], |
| - // [new RewriteTransformer("b", "z")] |
| - // ])] |
| - // ]}); |
| - // updateSources(["app|foo.a", "app|foo.x"]); |
| - // expectAsset("app|foo.c", "foo.b.c"); |
| - // expectAsset("app|foo.z", "foo.b.z"); |
| - // buildShouldSucceed(); |
| - // }); |
| + test("parallel groups' intermediate assets can't collide", () { |
| + initGraph(["app|foo.a", "app|foo.x"], {"app": [ |
| + [new TransformerGroup([ |
| + [new RewriteTransformer("a", "b")], |
| + [new RewriteTransformer("b", "c")..consumePrimary = true] |
| + ]), new TransformerGroup([ |
| + [new RewriteTransformer("x", "b")], |
| + [new RewriteTransformer("b", "z")..consumePrimary = true] |
| + ])] |
| + ]}); |
| + updateSources(["app|foo.a", "app|foo.x"]); |
|
Bob Nystrom
2014/03/07 21:54:11
Might be cool to expect that foo.a and foo.x are a
nweiz
2014/03/11 21:44:05
Done.
|
| + expectAsset("app|foo.c", "foo.b.c"); |
| + expectAsset("app|foo.z", "foo.b.z"); |
| + buildShouldSucceed(); |
| + }); |
| }); |
| group("pass-through", () { |
| @@ -299,6 +297,35 @@ main() { |
| buildShouldSucceed(); |
| }); |
| + test("doesn't pass through an input that's consumed by a group but not " |
| + "by transformers", () { |
| + initGraph(["app|foo.a"], {"app": [[ |
| + new TransformerGroup([ |
| + [new RewriteTransformer("a", "b")..consumePrimary = true], |
| + ]), |
| + new RewriteTransformer("x", "y") |
| + ]]}); |
| + updateSources(["app|foo.a"]); |
| + expectNoAsset("app|foo.a"); |
| + expectAsset("app|foo.b", "foo.b"); |
| + buildShouldSucceed(); |
| + }); |
| + |
| + test("doesn't pass through an input that's consumed by transformers but " |
| + "not by a group", () { |
| + initGraph(["app|foo.x"], {"app": [[ |
| + new TransformerGroup([ |
| + [new RewriteTransformer("a", "b")], |
| + [new RewriteTransformer("b", "c")] |
| + ]), |
| + new RewriteTransformer("x", "y")..consumePrimary = true |
| + ]]}); |
| + updateSources(["app|foo.x"]); |
| + expectNoAsset("app|foo.x"); |
| + expectAsset("app|foo.y", "foo.y"); |
| + buildShouldSucceed(); |
| + }); |
| + |
| test("doesn't detect a collision for an input that's modified in-place by " |
| "a transformer", () { |
| initGraph(["app|foo.x"], {"app": [[ |