Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 1912203002: Revert of WTF: Implement explicit RefPtr::operator bool. (Closed)

Created:
4 years, 8 months ago by jbroman
Modified:
4 years, 8 months ago
Reviewers:
sof, Yuta Kitamura, Nico
CC:
ajuma+watch-canvas_chromium.org, darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-layout_chromium.org, blink-reviews-platform-graphics_chromium.org, blink-reviews-style_chromium.org, blink-reviews-wtf_chromium.org, Rik, caseq+blink_chromium.org, chromium-reviews, danakj+watch_chromium.org, devtools-reviews_chromium.org, dglazkov+blink, dshwang, drott+blinkwatch_chromium.org, krit, eae+blinkwatch, f(malita), gavinp+loader_chromium.org, Nate Chapin, jchaffraix+rendering, Justin Novosad, kinuko+watch, kozyatinskiy+blink_chromium.org, leviw+renderwatch, loading-reviews+fetch_chromium.org, lushnikov+blink_chromium.org, Mikhail, pdr+renderingwatchlist_chromium.org, pdr+graphicswatchlist_chromium.org, pfeldman+blink_chromium.org, rwlbuis, Stephen Chennney, sergeyv+blink_chromium.org, szager+layoutwatch_chromium.org, tyoshino+watch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of WTF: Implement explicit RefPtr::operator bool. (patchset #2 id:20001 of https://codereview.chromium.org/1891473002/ ) Reason for revert: Possible cause of performance regressions, somehow? https://bugs.chromium.org/p/chromium/issues/detail?id=605080 Original issue's description: > WTF: Implement explicit RefPtr::operator bool. > > This is the modern alternative to the "safe bool" idiom. Some changes at > call sites are required, primarily because returning a boolean does not > cause an explicit conversion. TBR=thakis@chromium.org,yutak@chromium.org,sigbjornf@opera.com BUG=605080 # Not skipping CQ checks because original CL landed more than 1 days ago. Committed: https://crrev.com/1f735b48f731259f08b4fd7d46da0bfba5cb0911 Cr-Commit-Position: refs/heads/master@{#389192}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -62 lines) Patch
M third_party/WebKit/Source/core/css/LocalFontFaceSource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/SubstituteData.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/NetworkResourcesData.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutCounter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/PODRedBlackTree.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/FontDataForRangeSet.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/SimpleFontData.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/shaping/CachingWordShapeIterator.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/PassRefPtr.h View 3 chunks +5 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/wtf/RefPtr.h View 3 chunks +5 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/wtf/typed_arrays/ArrayBufferBuilder.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/typed_arrays/ArrayBufferView.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
jbroman
Created Revert of WTF: Implement explicit RefPtr::operator bool.
4 years, 8 months ago (2016-04-22 17:36:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1912203002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1912203002/1
4 years, 8 months ago (2016-04-22 17:36:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1912203002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1912203002/1
4 years, 8 months ago (2016-04-22 18:01:54 UTC) #4
Nico
wow, that'd be surprising. i'm curious if this helps.
4 years, 8 months ago (2016-04-22 18:30:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1912203002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1912203002/1
4 years, 8 months ago (2016-04-22 18:32:12 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-22 18:59:27 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:50:49 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1f735b48f731259f08b4fd7d46da0bfba5cb0911
Cr-Commit-Position: refs/heads/master@{#389192}

Powered by Google App Engine
This is Rietveld 408576698