Created Revert of WTF: Implement explicit RefPtr::operator bool.
4 years, 8 months ago
(2016-04-22 17:36:18 UTC)
#1
Created Revert of WTF: Implement explicit RefPtr::operator bool.
jbroman
Description was changed from ========== Revert of WTF: Implement explicit RefPtr::operator bool. (patchset #2 id:20001 ...
4 years, 8 months ago
(2016-04-22 17:36:33 UTC)
#2
Description was changed from
==========
Revert of WTF: Implement explicit RefPtr::operator bool. (patchset #2 id:20001
of https://codereview.chromium.org/1891473002/ )
Reason for revert:
Possible cause of performance regressions, somehow?
https://bugs.chromium.org/p/chromium/issues/detail?id=605080
Original issue's description:
> WTF: Implement explicit RefPtr::operator bool.
>
> This is the modern alternative to the "safe bool" idiom. Some changes at
> call sites are required, primarily because returning a boolean does not
> cause an explicit conversion.
TBR=thakis@chromium.org,yutak@chromium.org,sigbjornf@opera.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
==========
to
==========
Revert of WTF: Implement explicit RefPtr::operator bool. (patchset #2 id:20001
of https://codereview.chromium.org/1891473002/ )
Reason for revert:
Possible cause of performance regressions, somehow?
https://bugs.chromium.org/p/chromium/issues/detail?id=605080
Original issue's description:
> WTF: Implement explicit RefPtr::operator bool.
>
> This is the modern alternative to the "safe bool" idiom. Some changes at
> call sites are required, primarily because returning a boolean does not
> cause an explicit conversion.
TBR=thakis@chromium.org,yutak@chromium.org,sigbjornf@opera.com
BUG=605080
# Not skipping CQ checks because original CL landed more than 1 days ago.
==========
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1912203002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1912203002/1
4 years, 8 months ago
(2016-04-22 17:36:47 UTC)
#3
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1912203002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1912203002/1
4 years, 8 months ago
(2016-04-22 18:01:54 UTC)
#4
wow, that'd be surprising. i'm curious if this helps.
4 years, 8 months ago
(2016-04-22 18:30:44 UTC)
#5
wow, that'd be surprising. i'm curious if this helps.
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1912203002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1912203002/1
4 years, 8 months ago
(2016-04-22 18:32:12 UTC)
#6
Issue 1912203002: Revert of WTF: Implement explicit RefPtr::operator bool.
(Closed)
Created 4 years, 8 months ago by jbroman
Modified 4 years, 8 months ago
Reviewers: sof, Nico, Yuta Kitamura
Base URL: https://chromium.googlesource.com/chromium/src.git@master
Comments: 0