blimp/common/blob_cache/in_memory_blob_cache.cc - Issue 1912153004: [blimp] Change to use SHA-256 instead of SHA-1 for unique ids

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/common/blob_cache/in_memory_blob_cache.cc

Issue 1912153004: [blimp] Change to use SHA-256 instead of SHA-1 for unique ids (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments from Wez Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: blimp/common/blob_cache/in_memory_blob_cache.cc

diff --git a/blimp/common/blob_cache/in_memory_blob_cache.cc b/blimp/common/blob_cache/in_memory_blob_cache.cc

index fbdfe50b7e06986a1b9bbc6040154b0d3aae9a58..bad46df059937c7849f89da6a897de8e93114612 100644

--- a/blimp/common/blob_cache/in_memory_blob_cache.cc

+++ b/blimp/common/blob_cache/in_memory_blob_cache.cc

@@ -5,9 +5,6 @@

#include "blimp/common/blob_cache/in_memory_blob_cache.h"

#include "base/logging.h"

-#include "base/sha1.h"

-#include "base/strings/string_number_conversions.h"

-#include "base/strings/string_util.h"

namespace blimp {

« no previous file with comments | « blimp/common/blob_cache/id_util_unittest.cc ('k') | blimp/common/compositor/webp_decoder.cc » ('j') | no next file with comments »