Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Unified Diff: src/compiler/register-allocator-verifier.cc

Issue 1912093005: [turbofan] Single entry into deferred regions (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/register-allocator-verifier.h ('k') | src/compiler/schedule.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/register-allocator-verifier.cc
diff --git a/src/compiler/register-allocator-verifier.cc b/src/compiler/register-allocator-verifier.cc
index f35cb266a91422940d885c96cc1f0d1e2b40ceb0..9b36b30e0291b2352d1a4e2cc65344d5e97c859f 100644
--- a/src/compiler/register-allocator-verifier.cc
+++ b/src/compiler/register-allocator-verifier.cc
@@ -282,9 +282,7 @@ void BlockAssessments::PerformParallelMoves(const ParallelMove* moves) {
CHECK(it != map_.end());
// The LHS of a parallel move should not have been assigned in this
// parallel move.
- // TODO(mtrofin): this check fails when generating code for
- // CodeStubAssembler::ChangeUint32ToTagged.
- // CHECK(map_for_moves_.find(move->destination()) == map_for_moves_.end());
+ CHECK(map_for_moves_.find(move->destination()) == map_for_moves_.end());
// Copy the assessment to the destination.
map_for_moves_[move->destination()] = it->second;
}
@@ -418,7 +416,7 @@ void RegisterAllocatorVerifier::ValidatePendingAssessment(
case Pending: {
// This happens if we have a diamond feeding into another one, and
// the inner one never being used - other than for carrying the value.
- PendingAssessment* next = PendingAssessment::cast(contribution);
+ const PendingAssessment* next = PendingAssessment::cast(contribution);
if (seen.find(pred) == seen.end()) {
worklist.push({next, expected});
seen.insert(pred);
« no previous file with comments | « src/compiler/register-allocator-verifier.h ('k') | src/compiler/schedule.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698