Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1912063003: [NTP Snippets] Stop refreshing the snippets on tab switch (Closed)

Created:
4 years, 8 months ago by dgn
Modified:
4 years, 8 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, dgn+watch_chromium.org, mcwilliams+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NTP Snippets] Stop refreshing the snippets on tab switch BUG=601757 Committed: https://crrev.com/68ab5d959f461256078f83f975c9521395aeeb08 Cr-Commit-Position: refs/heads/master@{#389084}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -61 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java View 2 chunks +0 lines, -10 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java View 4 chunks +0 lines, -41 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
dgn
PTAL
4 years, 8 months ago (2016-04-22 11:42:32 UTC) #2
Bernhard Bauer
lgtm
4 years, 8 months ago (2016-04-22 11:45:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1912063003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1912063003/1
4 years, 8 months ago (2016-04-22 11:46:34 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-22 12:26:58 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:46:37 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/68ab5d959f461256078f83f975c9521395aeeb08
Cr-Commit-Position: refs/heads/master@{#389084}

Powered by Google App Engine
This is Rietveld 408576698