Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1912023002: Remove #ifdef platform which is always true. (Closed)

Created:
4 years, 8 months ago by Tom Sepez
Modified:
4 years, 8 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove #ifdef platform which is always true. fx_system.h errors out during compile if _FXM_PLATFORM_ is not one of the four values tested in the ifdef. Remove duplicated code, and use unique_ptr for cleanup. Committed: https://pdfium.googlesource.com/pdfium/+/2178e48e9dc62143f0442c520807606a3ac5f042

Patch Set 1 #

Patch Set 2 : Tigher code #

Patch Set 3 : Make string ctor match Left(4), just because. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -37 lines) Patch
M core/fpdfapi/fpdf_font/cpdf_font.cpp View 1 2 2 chunks +15 lines, -37 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Tom Sepez
Lei, for review.
4 years, 8 months ago (2016-04-22 02:14:40 UTC) #2
Lei Zhang
lgtm
4 years, 8 months ago (2016-04-22 02:26:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1912023002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1912023002/40001
4 years, 8 months ago (2016-04-22 15:15:49 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 15:16:09 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/2178e48e9dc62143f0442c520807606a3ac5...

Powered by Google App Engine
This is Rietveld 408576698