Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1911983002: Subzero: Provide missing isMemoryWrite() method. (Closed)

Created:
4 years, 8 months ago by Jim Stichnoth
Modified:
4 years, 8 months ago
Reviewers:
John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: Provide missing isMemoryWrite() method. This is the result of an improper rebase in the previous CL. BUG= none R=jpp@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=cd261e9187a065dc7b917af8f2f8ff435fcf4c15

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/IceInst.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Jim Stichnoth
4 years, 8 months ago (2016-04-22 00:54:48 UTC) #3
John
lgtm
4 years, 8 months ago (2016-04-22 00:57:40 UTC) #4
Jim Stichnoth
4 years, 8 months ago (2016-04-22 00:58:03 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
cd261e9187a065dc7b917af8f2f8ff435fcf4c15 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698