Fix scrollbar buttons at hidpi when enable-use-zoom-for-dsf is on.

ui/native_theme/native_theme_base.cc

Index: ui/native_theme/native_theme_base.cc
diff --git a/ui/native_theme/native_theme_base.cc b/ui/native_theme/native_theme_base.cc
index cc94eafb7b432d0af3abfcb0c9dcabb5b9cde16b..6e91ea824bb6d1d5c4fbddfd509f376edc9b8864 100644
--- a/ui/native_theme/native_theme_base.cc
+++ b/ui/native_theme/native_theme_base.cc
@@ -358,50 +358,52 @@ void NativeThemeBase::PaintArrow(SkCanvas* gc,
                                  const gfx::Rect& rect,
                                  Part direction,
                                  SkColor color) const {
-  int width_middle, length_middle;
-  if (direction == kScrollbarUpArrow || direction == kScrollbarDownArrow) {
-    width_middle = rect.width() / 2 + 1;
-    length_middle = rect.height() / 2 + 1;
-  } else {
-    length_middle = rect.width() / 2 + 1;
-    width_middle = rect.height() / 2 + 1;
-  }
-
   SkPaint paint;
   paint.setColor(color);
   paint.setAntiAlias(false);

[Evan Stade, 2016/05/12 01:10:59]

i think anti aliasing is false by default

[Bret, 2016/05/12 21:59:13]

*squints* Hmm, you are correct. Removed.

-  paint.setStyle(SkPaint::kFill_Style);
+
+  SkPath path = PathForArrow(rect, direction);
+
+  gc->drawPath(path, paint);
+}
+
+SkPath NativeThemeBase::PathForArrow(const gfx::Rect& rect,
+                                     Part direction) const {
+  gfx::Rect bounding_rect(rect);
+  const int padding_width = ceil(rect.width() / 4.f);
+  const int padding_height = ceil(rect.height() / 4.f);
+  bounding_rect.Inset(padding_width, padding_height);
+  const gfx::Point center = bounding_rect.CenterPoint();
 
   SkPath path;
-  // The constants in this block of code are hand-tailored to produce good
-  // looking arrows without anti-aliasing.
-  switch (direction) {
-    case kScrollbarUpArrow:
-      path.moveTo(rect.x() + width_middle - 4, rect.y() + length_middle + 2);
-      path.rLineTo(7, 0);
-      path.rLineTo(-4, -4);
-      break;
-    case kScrollbarDownArrow:
-      path.moveTo(rect.x() + width_middle - 4, rect.y() + length_middle - 3);
-      path.rLineTo(7, 0);
-      path.rLineTo(-4, 4);
-      break;
-    case kScrollbarRightArrow:
-      path.moveTo(rect.x() + length_middle - 3, rect.y() + width_middle - 4);
-      path.rLineTo(0, 7);
-      path.rLineTo(4, -4);
-      break;
-    case kScrollbarLeftArrow:
-      path.moveTo(rect.x() + length_middle + 1, rect.y() + width_middle - 5);
-      path.rLineTo(0, 9);
-      path.rLineTo(-4, -4);
-      break;
-    default:
-      break;
+  SkMatrix transform;
+  transform.setIdentity();
+  if (direction == kScrollbarUpArrow || direction == kScrollbarDownArrow) {
+    int arrow_altitude = bounding_rect.height() / 2 + 1;
+    path.moveTo(bounding_rect.x(), bounding_rect.y() + bounding_rect.height());

[Evan Stade, 2016/05/12 01:10:59]

nit: bottom()

[Bret, 2016/05/12 21:59:13]

Done.

+    path.rLineTo(bounding_rect.width(), 0);
+    path.rLineTo(-bounding_rect.width() / 2.0f, -arrow_altitude);
+    path.close();
+    path.offset(0, -arrow_altitude / 2 + 1);
+    if (direction == kScrollbarDownArrow) {
+      path.offset(0, -1);
+      transform.setScale(1, -1, center.x(), center.y());
+    }
+  } else {
+    int arrow_altitude = bounding_rect.width() / 2 + 1;
+    path.moveTo(bounding_rect.x(), bounding_rect.y());
+    path.rLineTo(0, bounding_rect.height());
+    path.rLineTo(arrow_altitude, -bounding_rect.height() / 2.0f);
+    path.close();
+    path.offset(arrow_altitude / 2, 0);
+    if (direction == kScrollbarLeftArrow) {
+      path.offset(-1, 0);
+      transform.setScale(-1, 1, center.x(), center.y());
+    }
   }
-  path.close();
+  path.transform(transform);
 
-  gc->drawPath(path, paint);
+  return path;
 }
 
 void NativeThemeBase::PaintScrollbarTrack(SkCanvas* canvas,