src/effects/SkDashPathEffect.cpp - Issue 1911963008: DNC - JSON of flattenables, with field names.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkDashPathEffect.cpp

Issue 1911963008: DNC - JSON of flattenables, with field names. Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Add names to call sites Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/SkDashPathEffect.cpp

diff --git a/src/effects/SkDashPathEffect.cpp b/src/effects/SkDashPathEffect.cpp

index 90af32ec5b0fb6686699271f2c888704207a65d4..c68f525c7471c12cc04a64824bb3ff5d4c828c13 100644

--- a/src/effects/SkDashPathEffect.cpp

+++ b/src/effects/SkDashPathEffect.cpp

@@ -356,8 +356,8 @@ SkPathEffect::DashType SkDashPathEffect::asADash(DashInfo* info) const {

}

void SkDashPathEffect::flatten(SkWriteBuffer& buffer) const {

- buffer.writeScalar(fPhase);

- buffer.writeScalarArray(fIntervals, fCount);

+ buffer.writeScalar("fPhase", fPhase);

+ buffer.writeScalarArray("fIntervals", fIntervals, fCount);

}

sk_sp<SkFlattenable> SkDashPathEffect::CreateProc(SkReadBuffer& buffer) {