src/effects/SkColorCubeFilter.cpp - Issue 1911963008: DNC - JSON of flattenables, with field names.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkColorCubeFilter.cpp

Issue 1911963008: DNC - JSON of flattenables, with field names. Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Add names to call sites Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/SkColorCubeFilter.cpp

diff --git a/src/effects/SkColorCubeFilter.cpp b/src/effects/SkColorCubeFilter.cpp

index fdf571cbf3745b06c7a985d99512bf853c0d87b2..d6d8e1320aa041ee56cb72537c532932ce870289 100644

--- a/src/effects/SkColorCubeFilter.cpp

+++ b/src/effects/SkColorCubeFilter.cpp

@@ -146,8 +146,8 @@ sk_sp<SkFlattenable> SkColorCubeFilter::CreateProc(SkReadBuffer& buffer) {

void SkColorCubeFilter::flatten(SkWriteBuffer& buffer) const {

this->INHERITED::flatten(buffer);

- buffer.writeInt(fCache.cubeDimension());

- buffer.writeDataAsByteArray(fCubeData.get());

+ buffer.writeInt("cubeDimension", fCache.cubeDimension());

+ buffer.writeDataAsByteArray("fCubeData", fCubeData.get());

}

#ifndef SK_IGNORE_TO_STRING