src/core/SkPathEffect.cpp - Issue 1911963008: DNC - JSON of flattenables, with field names.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkPathEffect.cpp

Issue 1911963008: DNC - JSON of flattenables, with field names. Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Add names to call sites Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkPathEffect.cpp

diff --git a/src/core/SkPathEffect.cpp b/src/core/SkPathEffect.cpp

index 1178348af530a8972ff4f7d0f61d09dc6df608bf..ac737c94998e1dd231d3ad4e0f734106375212a9 100644

--- a/src/core/SkPathEffect.cpp

+++ b/src/core/SkPathEffect.cpp

@@ -38,8 +38,8 @@ SkPairPathEffect::SkPairPathEffect(sk_sp<SkPathEffect> pe0, sk_sp<SkPathEffect>

Format: [oe0-factory][pe1-factory][pe0-size][pe0-data][pe1-data]

void SkPairPathEffect::flatten(SkWriteBuffer& buffer) const {

- buffer.writeFlattenable(fPE0.get());

- buffer.writeFlattenable(fPE1.get());

+ buffer.writeFlattenable("fPE0", fPE0.get());

+ buffer.writeFlattenable("fPE1", fPE1.get());

}

#ifndef SK_IGNORE_TO_STRING