src/core/SkModeColorFilter.cpp - Issue 1911963008: DNC - JSON of flattenables, with field names.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkModeColorFilter.cpp

Issue 1911963008: DNC - JSON of flattenables, with field names. Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Add names to call sites Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkModeColorFilter.cpp

diff --git a/src/core/SkModeColorFilter.cpp b/src/core/SkModeColorFilter.cpp

index eacd261b5cb97eccecbfde904c29f817359d2058..e03b40ec5928ffb2410369d952bd8ab2fc17c045 100644

--- a/src/core/SkModeColorFilter.cpp

+++ b/src/core/SkModeColorFilter.cpp

@@ -68,8 +68,8 @@ void SkModeColorFilter::filterSpan4f(const SkPM4f shader[], int count, SkPM4f re

}

void SkModeColorFilter::flatten(SkWriteBuffer& buffer) const {

- buffer.writeColor(fColor);

- buffer.writeUInt(fMode);

+ buffer.writeColor("fColor", fColor);

+ buffer.writeUInt("fMode", fMode);

}

void SkModeColorFilter::updateCache() {