src/core/SkLocalMatrixImageFilter.cpp - Issue 1911963008: DNC - JSON of flattenables, with field names.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkLocalMatrixImageFilter.cpp

Issue 1911963008: DNC - JSON of flattenables, with field names. Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Add names to call sites Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkLocalMatrixImageFilter.cpp

diff --git a/src/core/SkLocalMatrixImageFilter.cpp b/src/core/SkLocalMatrixImageFilter.cpp

index b4d5bb2741ead830612b99463719ac1d7cd27599..1f059dc9e47aa752d9637275910fa8247a48643f 100644

--- a/src/core/SkLocalMatrixImageFilter.cpp

+++ b/src/core/SkLocalMatrixImageFilter.cpp

@@ -39,7 +39,7 @@ sk_sp<SkFlattenable> SkLocalMatrixImageFilter::CreateProc(SkReadBuffer& buffer)

void SkLocalMatrixImageFilter::flatten(SkWriteBuffer& buffer) const {

this->INHERITED::flatten(buffer);

- buffer.writeMatrix(fLocalM);

+ buffer.writeMatrix("fLocalM", fLocalM);

}

sk_sp<SkSpecialImage> SkLocalMatrixImageFilter::onFilterImage(SkSpecialImage* source,