src/core/SkFlattenableSerialization.cpp - Issue 1911963008: DNC - JSON of flattenables, with field names.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkFlattenableSerialization.cpp

Issue 1911963008: DNC - JSON of flattenables, with field names. Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Add names to call sites Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkFlattenableSerialization.cpp

diff --git a/src/core/SkFlattenableSerialization.cpp b/src/core/SkFlattenableSerialization.cpp

index 06e8c1070616c1dc2aa76cf3720389a2abbdef93..f40740f7c8b3597cc8b2031a063e30dccbf61027 100644

--- a/src/core/SkFlattenableSerialization.cpp

+++ b/src/core/SkFlattenableSerialization.cpp

@@ -13,7 +13,7 @@

SkData* SkValidatingSerializeFlattenable(SkFlattenable* flattenable) {

SkWriteBuffer writer;

- writer.writeFlattenable(flattenable);

+ writer.writeFlattenable("flattenable", flattenable);

size_t size = writer.bytesWritten();

auto data = SkData::MakeUninitialized(size);

writer.writeToMemory(data->writable_data());