src/core/SkColorMatrixFilterRowMajor255.cpp - Issue 1911963008: DNC - JSON of flattenables, with field names.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkColorMatrixFilterRowMajor255.cpp

Issue 1911963008: DNC - JSON of flattenables, with field names. Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Add names to call sites Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkColorMatrixFilterRowMajor255.cpp

diff --git a/src/core/SkColorMatrixFilterRowMajor255.cpp b/src/core/SkColorMatrixFilterRowMajor255.cpp

index c158a7948fec040847f47d635f155ec988d7a4b0..bad7ca3fbc4256b9d7a3dc977794b99a2cfcab5b 100644

--- a/src/core/SkColorMatrixFilterRowMajor255.cpp

+++ b/src/core/SkColorMatrixFilterRowMajor255.cpp

@@ -154,7 +154,7 @@ void SkColorMatrixFilterRowMajor255::filterSpan4f(const SkPM4f src[], int count,

void SkColorMatrixFilterRowMajor255::flatten(SkWriteBuffer& buffer) const {

SkASSERT(sizeof(fMatrix)/sizeof(SkScalar) == 20);

- buffer.writeScalarArray(fMatrix, 20);

+ buffer.writeScalarArray("fMatrix", fMatrix, 20);

}

sk_sp<SkFlattenable> SkColorMatrixFilterRowMajor255::CreateProc(SkReadBuffer& buffer) {