Add flag for disallowing for-in initializers

src/parsing/parser.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/parsing/parser.h"
 
 #include "src/api.h"
 #include "src/ast/ast.h"
 #include "src/ast/ast-expression-rewriter.h"
 #include "src/ast/ast-expression-visitor.h"
@@ skipping 3482 matching lines @@
           *ok = false;
           return nullptr;
         }
 
         Block* init_block = nullptr;
 
         // special case for legacy for (var/const x =.... in)
         if (!IsLexicalVariableMode(parsing_result.descriptor.mode) &&
             decl.pattern->IsVariableProxy() && decl.initializer != nullptr) {
           ++use_counts_[v8::Isolate::kForInInitializer];
+          if (FLAG_harmony_for_in) {

[nickie, 2016/04/22 11:22:56]

Shouldn't a similar thing be added to the preparser?

[rossberg, 2016/04/22 11:34:50]

Yes, normally it should. However, we'd lose use counts if we already rejected it
in the preparser. So I'm inclined to leave it like that as a temporary measure.
I added a TODO comment explaining this.

[adamk, 2016/04/22 17:28:18]

This inconsistency seems like it'll cause us some headaches if people actually
start reporting bugs about this feature. You could instead add a bit of API to
the ParserRecorder and copy that over to the use_counts_ in
ParseLazyFunctionBodyWithPreParser. If you feel that's too complex for this
feature, than I'd rather lose the UseCounter data then have this inconsistency
in behavior.

+            ParserTraits::ReportMessageAt(
+                parsing_result.first_initializer_loc,
+                MessageTemplate::kForInOfLoopInitializer,
+                ForEachStatement::VisitModeString(mode));
+            *ok = false;
+            return nullptr;
+          }
           const AstRawString* name =
               decl.pattern->AsVariableProxy()->raw_name();
           VariableProxy* single_var = scope_->NewUnresolved(
               factory(), name, Variable::NORMAL, each_beg_pos, each_end_pos);
           init_block = factory()->NewBlock(
               nullptr, 2, true, parsing_result.descriptor.declaration_pos);
           init_block->statements()->Add(
               factory()->NewExpressionStatement(
                   factory()->NewAssignment(Token::ASSIGN, single_var,
                                            decl.initializer,
@@ skipping 3270 matching lines @@
                         try_block, target);
     final_loop = target;
   }
 
   return final_loop;
 }
 
 
 }  // namespace internal
 }  // namespace v8