MD Settings: Tweak "View reported settings" UI in reset settings profile.

MD Settings: Tweak "View reported settings" UI in reset settings profile.

BUG=603709
Committed: https://crrev.com/cfc480b7040cddca093748c383ea1c3299d9088f
Cr-Commit-Position: refs/heads/master@{#389581}

[dpapad, 2016-04-22 00:47:32]

dpapad@chromium.org changed reviewers:
+ dschuyler@chromium.org

[dpapad, 2016-04-22 00:47:33]

Before screenshots at http://imgur.com/a/LbWBS, after screenshots at
http://imgur.com/a/bJgmu.

[dpapad, 2016-04-22 20:25:12]

On 2016/04/22 at 00:47:33, dpapad wrote:
> Before screenshots at http://imgur.com/a/LbWBS, after screenshots at
http://imgur.com/a/bJgmu.

Friendly ping.

[dschuyler, 2016-04-23 00:57:34]

https://codereview.chromium.org/1911943002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/reset_page/reset_profile_dialog.html
(right):

https://codereview.chromium.org/1911943002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/reset_page/reset_profile_dialog.html:43: <link
rel="import" type="css" href="chrome://resources/css/action_link.css">
I'm hoping to avoid adding css imports :)
Can this be made into a style-module?

https://codereview.chromium.org/1911943002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/reset_page/reset_profile_dialog.js
(right):

https://codereview.chromium.org/1911943002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/reset_page/reset_profile_dialog.js:55: return
entry.key + ': ' + entry.value.replace(/\n/g, ', ');
Could the line endings contain \r as well (e.g. on Windows)?

[dpapad, 2016-04-23 01:18:13]

https://codereview.chromium.org/1911943002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/reset_page/reset_profile_dialog.html
(right):

https://codereview.chromium.org/1911943002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/reset_page/reset_profile_dialog.html:43: <link
rel="import" type="css" href="chrome://resources/css/action_link.css">
On 2016/04/23 at 00:57:34, dschuyler wrote:
> I'm hoping to avoid adding css imports :)
> Can this be made into a style-module?

action-link predates Polymerized code in WebUI and therefore is used by
non-Polymer code that can't just import style modules. Turning it into a style
module would probably require duplicating the style from the CSS file instead of
sharing it.

@dbeam who introduced action-link in md-settings
(https://codereview.chromium.org/1725183002/diff/20001/chrome/browser/resource...)
might be a better person to address this.

https://codereview.chromium.org/1911943002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/reset_page/reset_profile_dialog.js
(right):

https://codereview.chromium.org/1911943002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/reset_page/reset_profile_dialog.js:55: return
entry.key + ': ' + entry.value.replace(/\n/g, ', ');
On 2016/04/23 at 00:57:34, dschuyler wrote:
> Could the line endings contain \r as well (e.g. on Windows)?

This data comes from
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/pro...,
wher eit seems that the \n characters are added in code and not read from a
file.

[Dan Beam, 2016-04-25 18:52:17]

dbeam@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2016-04-25 18:52:17]

https://codereview.chromium.org/1911943002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/reset_page/reset_profile_dialog.html
(right):

https://codereview.chromium.org/1911943002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/reset_page/reset_profile_dialog.html:43: <link
rel="import" type="css" href="chrome://resources/css/action_link.css">
On 2016/04/23 01:18:13, dpapad wrote:
> On 2016/04/23 at 00:57:34, dschuyler wrote:
> > I'm hoping to avoid adding css imports :)
> > Can this be made into a style-module?
> 
> action-link predates Polymerized code in WebUI and therefore is used by
> non-Polymer code that can't just import style modules. Turning it into a style
> module would probably require duplicating the style from the CSS file instead
of
> sharing it.
> 
> @dbeam who introduced action-link in md-settings
>
(https://codereview.chromium.org/1725183002/diff/20001/chrome/browser/resource...)
> might be a better person to address this.

just use <link rel="stylesheet"> instead of <link rel="import" type="css">

[Dan Beam, 2016-04-25 18:52:27]

Description was changed from

==========
MD Settings: Tweak "View reported settings" UI in reset settings profile.

BUG=603709
==========

to

==========
MD Settings: Tweak "View reported settings" UI in reset settings profile.

BUG=603709
==========

[Dan Beam, 2016-04-25 18:52:27]

dbeam@chromium.org changed reviewers:
- dbeam@chromium.org

[dpapad, 2016-04-25 19:09:37]

https://codereview.chromium.org/1911943002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/reset_page/reset_profile_dialog.html
(right):

https://codereview.chromium.org/1911943002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/reset_page/reset_profile_dialog.html:43: <link
rel="import" type="css" href="chrome://resources/css/action_link.css">
On 2016/04/25 at 18:52:17, Dan Beam wrote:
> On 2016/04/23 01:18:13, dpapad wrote:
> > On 2016/04/23 at 00:57:34, dschuyler wrote:
> > > I'm hoping to avoid adding css imports :)
> > > Can this be made into a style-module?
> > 
> > action-link predates Polymerized code in WebUI and therefore is used by
> > non-Polymer code that can't just import style modules. Turning it into a
style
> > module would probably require duplicating the style from the CSS file
instead of
> > sharing it.
> > 
> > @dbeam who introduced action-link in md-settings
> >
(https://codereview.chromium.org/1725183002/diff/20001/chrome/browser/resource...)
> > might be a better person to address this.
> 
> just use <link rel="stylesheet"> instead of <link rel="import" type="css">

Tried this but it does not work. Polymer is also throwing a warning in the
console,
"HTML element <link> is ignored in shadow tree."

[Dan Beam, 2016-04-25 19:19:32]

dbeam@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2016-04-25 19:19:32]

https://codereview.chromium.org/1911943002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/reset_page/reset_profile_dialog.html
(right):

https://codereview.chromium.org/1911943002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/reset_page/reset_profile_dialog.html:43: <link
rel="import" type="css" href="chrome://resources/css/action_link.css">
On 2016/04/25 19:09:36, dpapad wrote:
> On 2016/04/25 at 18:52:17, Dan Beam wrote:
> > On 2016/04/23 01:18:13, dpapad wrote:
> > > On 2016/04/23 at 00:57:34, dschuyler wrote:
> > > > I'm hoping to avoid adding css imports :)
> > > > Can this be made into a style-module?
> > > 
> > > action-link predates Polymerized code in WebUI and therefore is used by
> > > non-Polymer code that can't just import style modules. Turning it into a
> style
> > > module would probably require duplicating the style from the CSS file
> instead of
> > > sharing it.
> > > 
> > > @dbeam who introduced action-link in md-settings
> > >
>
(https://codereview.chromium.org/1725183002/diff/20001/chrome/browser/resource...)
> > > might be a better person to address this.
> > 
> > just use <link rel="stylesheet"> instead of <link rel="import" type="css">
> 
> Tried this but it does not work. Polymer is also throwing a warning in the
> console,
> "HTML element <link> is ignored in shadow tree."

i'm getting same results.  let's just do an import for now, but maybe we should
rethink whether we want to use action-link in polymer.  other parts may be
broken as well.

[Dan Beam, 2016-04-25 19:19:42]

dbeam@chromium.org changed reviewers:
- dbeam@chromium.org

[dschuyler, 2016-04-25 20:22:07]

Thanks for looking into the css inclusion.
LGTM

[dpapad, 2016-04-25 20:32:12]

The CQ bit was checked by dpapad@chromium.org

[commit-bot: I haz the power, 2016-04-25 20:32:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1911943002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1911943002/1

[commit-bot: I haz the power, 2016-04-25 22:19:05]

Description was changed from

==========
MD Settings: Tweak "View reported settings" UI in reset settings profile.

BUG=603709
==========

to

==========
MD Settings: Tweak "View reported settings" UI in reset settings profile.

BUG=603709
==========

[commit-bot: I haz the power, 2016-04-25 22:19:06]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-25 22:20:03]

Description was changed from

==========
MD Settings: Tweak "View reported settings" UI in reset settings profile.

BUG=603709
==========

to

==========
MD Settings: Tweak "View reported settings" UI in reset settings profile.

BUG=603709

Committed: https://crrev.com/cfc480b7040cddca093748c383ea1c3299d9088f
Cr-Commit-Position: refs/heads/master@{#389581}
==========

[commit-bot: I haz the power, 2016-04-25 22:20:04]

Patchset 1 (id:??) landed as
https://crrev.com/cfc480b7040cddca093748c383ea1c3299d9088f
Cr-Commit-Position: refs/heads/master@{#389581}