media/audio/cras/cras_unified_unittest.cc - Issue 1911913002: Convert //media/audio from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/audio/cras/cras_unified_unittest.cc

Issue 1911913002: Convert //media/audio from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix cast + windows build Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/audio/cras/cras_unified_unittest.cc

diff --git a/media/audio/cras/cras_unified_unittest.cc b/media/audio/cras/cras_unified_unittest.cc

index 2bc199edf86487bd625fde2576d67639f4c2ef82..e204ec8ce72fd973e8b9a9b505c939e8b0d6c56a 100644

--- a/media/audio/cras/cras_unified_unittest.cc

+++ b/media/audio/cras/cras_unified_unittest.cc

@@ -98,7 +98,7 @@ class CrasUnifiedStreamTest : public testing::Test {

static const uint32_t kTestFramesPerPacket;

base::TestMessageLoop message_loop_;

- scoped_ptr<StrictMock<MockAudioManagerCras>, AudioManagerDeleter>

+ std::unique_ptr<StrictMock<MockAudioManagerCras>, AudioManagerDeleter>

danakj 2016/04/22 22:47:36 include memory

dcheng 2016/04/22 23:13:20 'related header'? I could see this one going eithe

mock_manager_;

private:

« media/audio/cras/cras_unified.h ('K') | « media/audio/cras/cras_unified.h ('k') | media/audio/fake_audio_input_stream.h » ('j') | media/audio/fake_audio_log_factory.cc » ('J')