Convert //media/audio from scoped_ptr to std::unique_ptr

chromecast/media/audio/cast_audio_manager_factory.cc

Index: chromecast/media/audio/cast_audio_manager_factory.cc
diff --git a/chromecast/media/audio/cast_audio_manager_factory.cc b/chromecast/media/audio/cast_audio_manager_factory.cc
index c6b77940525be6b534dfe58b1a01641585be3e96..3e62411bcee8fa2e9a460c9e2281bdf0c2fb5d7e 100644
--- a/chromecast/media/audio/cast_audio_manager_factory.cc
+++ b/chromecast/media/audio/cast_audio_manager_factory.cc
@@ -17,12 +17,12 @@ CastAudioManagerFactory::CastAudioManagerFactory(
 
 CastAudioManagerFactory::~CastAudioManagerFactory() {}
 
-scoped_ptr<::media::AudioManager, ::media::AudioManagerDeleter>
+std::unique_ptr<::media::AudioManager, ::media::AudioManagerDeleter>
 CastAudioManagerFactory::CreateInstance(
     scoped_refptr<base::SingleThreadTaskRunner> task_runner,
     scoped_refptr<base::SingleThreadTaskRunner> worker_task_runner,
     ::media::AudioLogFactory* audio_log_factory) {
-  return scoped_ptr<::media::AudioManager, ::media::AudioManagerDeleter>(
+  return std::unique_ptr<::media::AudioManager, ::media::AudioManagerDeleter>(

[danakj, 2016/04/22 22:47:35]

include memory, or use WrapUnique

[dcheng, 2016/04/22 23:13:19]

Can't use WrapUnique due to the custom deleter. Here's the fun part. From
https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes:
"If you rely on symbols from bar.h, don't count on the fact that you included
foo.h which (currently) includes bar.h: include bar.h yourself, unless foo.h
explicitly demonstrates its intent to provide you the symbols of bar.h."

Does interface.h demonstrate an intent to specifically expose headers like
<memory> to us? I feel like you could argue either way on this one.

[danakj, 2016/04/22 23:15:16]

The algorithm I used in my head is to look where the first definition of the
type comes from. Here it's local to this file so I expect an include. The return
type of the function comes from the header, so I don't for that one.

       new CastAudioManager(std::move(task_runner),
                            std::move(worker_task_runner), audio_log_factory,
                            backend_manager_));