Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 1911893002: Add compile guard for SkCanvas::LayerIter (Closed)

Created:
4 years, 8 months ago by robertphillips
Modified:
4 years, 8 months ago
Reviewers:
f(malita), reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M include/core/SkCanvas.h View 1 chunk +2 lines, -0 lines 0 comments Download
M public.bzl View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
robertphillips
4 years, 8 months ago (2016-04-21 22:08:36 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1911893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1911893002/1
4 years, 8 months ago (2016-04-21 22:08:48 UTC) #6
f(malita)
lgtm
4 years, 8 months ago (2016-04-21 22:12:05 UTC) #7
reed1
lgtm I presume the guard has already landed in chrome
4 years, 8 months ago (2016-04-21 22:13:35 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-21 22:18:59 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1911893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1911893002/1
4 years, 8 months ago (2016-04-21 22:21:18 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/cb61a6452fbf9b147dc9d3f31bf520efb0e2c7fd
4 years, 8 months ago (2016-04-21 22:22:17 UTC) #14
robertphillips
4 years, 8 months ago (2016-04-21 22:24:18 UTC) #15
Message was sent while issue was closed.
On 2016/04/21 22:13:35, reed1 wrote:
> lgtm
> 
> I presume the guard has already landed in chrome

Both Chrome & Android appear to be fine. This is just for the .bzl build.

Powered by Google App Engine
This is Rietveld 408576698