Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Issue 1911883002: Revert "Re-land: Add download_file_types.proto with ascii->binary conversion, as a resource." (Closed)

Created:
4 years, 8 months ago by stevenjb
Modified:
4 years, 8 months ago
Reviewers:
Nathan Parker, xyzzyz
CC:
chromium-reviews, grt+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Re-land: Add download_file_types.proto with ascii->binary conversion, as a resource." This reverts commit d6e8e6aaa8d07a0d576adbd2dafd0789b124660e. Note: This revert deletes some files / code that were modified later, but were fixes to this change and should be easily recoverable. BUG=605592 TBR=nparker@chromium.org, xyzzyz@chromium.org, Committed: https://crrev.com/90ade35dd2736cc1fa3eb9fc67e83640345b519b Cr-Commit-Position: refs/heads/master@{#388960}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -359 lines) Patch
M chrome/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/browser_resources.grd View 1 chunk +0 lines, -3 lines 0 comments Download
D chrome/browser/resources/safe_browsing/BUILD.gn View 1 chunk +0 lines, -42 lines 0 comments Download
D chrome/browser/resources/safe_browsing/README.md View 1 chunk +0 lines, -96 lines 0 comments Download
D chrome/browser/resources/safe_browsing/download_file_types.asciipb View 1 chunk +0 lines, -44 lines 0 comments Download
D chrome/browser/resources/safe_browsing/gen_file_type_proto.py View 1 chunk +0 lines, -63 lines 0 comments Download
M chrome/chrome_common.gypi View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/chrome_resources.gyp View 2 chunks +0 lines, -40 lines 0 comments Download
M chrome/common/safe_browsing/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/safe_browsing/download_file_types.proto View 1 chunk +0 lines, -65 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1911883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1911883002/1
4 years, 8 months ago (2016-04-21 21:55:45 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-22 00:00:39 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:41:53 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/90ade35dd2736cc1fa3eb9fc67e83640345b519b
Cr-Commit-Position: refs/heads/master@{#388960}

Powered by Google App Engine
This is Rietveld 408576698