Alternate workaround for VS 2015 Update 2 code-gen bug

Alternate workaround for VS 2015 Update 2 code-gen bug

The xsl transformation function 'translate' was broken by VS 2015 due to
a code-gen bug, reported to Microsoft as:
https://connect.microsoft.com/VisualStudio/feedback/details/2582138

After getting feedback from Microsoft on the bug it became clear that
the original workaround was not stable, and could fail in the face of
PGO builds which change the optimization settings.

This is the recommended fix - introducing a copy of 'ch'.

This change also fixes some indentation errors caused by mixed tabs and
spaces in order to make it easier to see the correctness of the new
scoping.

There is now a layout test to check for this bug so no manual testing is
required for this CL.

BUG=599427, 440500
Committed: https://crrev.com/776e8a67c0e7fe1cf9399605f857aa93daf4c1ed
Cr-Commit-Position: refs/heads/master@{#389119}

[brucedawson, 2016-04-21 20:41:12]

Description was changed from

==========
Alternate workaround for VS 2015 Update 2 code-gen bug

After getting feedback from Microsoft on the bug:
https://connect.microsoft.com/VisualStudio/feedback/details/2582138
it became clear that the original workaround was not stable, and could
fail in the face of PGO builds which change the optimization settings.

This was the recommended fix.

This change also fixes some indentation errors caused by mixed tabs and
spaces in order to make it easier to see the correctness of the new
scoping.

BUG=599427,440500
==========

to

==========
Alternate workaround for VS 2015 Update 2 code-gen bug

The xsl transformation function 'translate' was broken by VS 2015 due to
a code-gen bug, reported to Microsoft as:
https://connect.microsoft.com/VisualStudio/feedback/details/2582138

After getting feedback from Microsoft on the bug it became clear that
the original workaround was not stable, and could fail in the face of
PGO builds which change the optimization settings.

This is the recommended fix - introducing a copy of 'ch'.

This change also fixes some indentation errors caused by mixed tabs and
spaces in order to make it easier to see the correctness of the new
scoping.

There is now a layout test to check for this bug so no manual testing is
required for this CL.

BUG=599427,440500
==========

[brucedawson, 2016-04-21 20:41:12]

brucedawson@chromium.org changed reviewers:
+ dominicc@chromium.org

[brucedawson, 2016-04-22 00:08:53]

PTAL - details in the description.

[scottmg, 2016-04-22 02:15:51]

scottmg@chromium.org changed reviewers:
+ scottmg@chromium.org

[scottmg, 2016-04-22 02:15:52]

lgtm

[dominicc (has gone to gerrit), 2016-04-22 05:15:15]

lgtm

[brucedawson, 2016-04-22 15:44:17]

The CQ bit was checked by brucedawson@chromium.org

[commit-bot: I haz the power, 2016-04-22 15:44:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1911853002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1911853002/1

[commit-bot: I haz the power, 2016-04-22 15:49:34]

Description was changed from

==========
Alternate workaround for VS 2015 Update 2 code-gen bug

The xsl transformation function 'translate' was broken by VS 2015 due to
a code-gen bug, reported to Microsoft as:
https://connect.microsoft.com/VisualStudio/feedback/details/2582138

After getting feedback from Microsoft on the bug it became clear that
the original workaround was not stable, and could fail in the face of
PGO builds which change the optimization settings.

This is the recommended fix - introducing a copy of 'ch'.

This change also fixes some indentation errors caused by mixed tabs and
spaces in order to make it easier to see the correctness of the new
scoping.

There is now a layout test to check for this bug so no manual testing is
required for this CL.

BUG=599427,440500
==========

to

==========
Alternate workaround for VS 2015 Update 2 code-gen bug

The xsl transformation function 'translate' was broken by VS 2015 due to
a code-gen bug, reported to Microsoft as:
https://connect.microsoft.com/VisualStudio/feedback/details/2582138

After getting feedback from Microsoft on the bug it became clear that
the original workaround was not stable, and could fail in the face of
PGO builds which change the optimization settings.

This is the recommended fix - introducing a copy of 'ch'.

This change also fixes some indentation errors caused by mixed tabs and
spaces in order to make it easier to see the correctness of the new
scoping.

There is now a layout test to check for this bug so no manual testing is
required for this CL.

BUG=599427,440500
==========

[commit-bot: I haz the power, 2016-04-22 15:49:35]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-22 19:47:54]

Description was changed from

==========
Alternate workaround for VS 2015 Update 2 code-gen bug

The xsl transformation function 'translate' was broken by VS 2015 due to
a code-gen bug, reported to Microsoft as:
https://connect.microsoft.com/VisualStudio/feedback/details/2582138

After getting feedback from Microsoft on the bug it became clear that
the original workaround was not stable, and could fail in the face of
PGO builds which change the optimization settings.

This is the recommended fix - introducing a copy of 'ch'.

This change also fixes some indentation errors caused by mixed tabs and
spaces in order to make it easier to see the correctness of the new
scoping.

There is now a layout test to check for this bug so no manual testing is
required for this CL.

BUG=599427,440500
==========

to

==========
Alternate workaround for VS 2015 Update 2 code-gen bug

The xsl transformation function 'translate' was broken by VS 2015 due to
a code-gen bug, reported to Microsoft as:
https://connect.microsoft.com/VisualStudio/feedback/details/2582138

After getting feedback from Microsoft on the bug it became clear that
the original workaround was not stable, and could fail in the face of
PGO builds which change the optimization settings.

This is the recommended fix - introducing a copy of 'ch'.

This change also fixes some indentation errors caused by mixed tabs and
spaces in order to make it easier to see the correctness of the new
scoping.

There is now a layout test to check for this bug so no manual testing is
required for this CL.

BUG=599427,440500

Committed: https://crrev.com/776e8a67c0e7fe1cf9399605f857aa93daf4c1ed
Cr-Commit-Position: refs/heads/master@{#389119}
==========

[commit-bot: I haz the power, 2016-04-22 19:47:55]

Patchset 1 (id:??) landed as
https://crrev.com/776e8a67c0e7fe1cf9399605f857aa93daf4c1ed
Cr-Commit-Position: refs/heads/master@{#389119}