Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 1911843002: Remove IFDE_CSSTagProvider. (Closed)

Created:
4 years, 8 months ago by dsinclair
Modified:
4 years, 8 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove IFDE_CSSTagProvider. There is only one subsclass, use that instead. Remove the use of WideStringC in the API. BUG=pdfium:468 Committed: https://pdfium.googlesource.com/pdfium/+/bc1cbabe8d8bfa74d25160c14afa30d5b40df335

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -104 lines) Patch
M xfa/fde/css/fde_css.h View 4 chunks +3 lines, -12 lines 0 comments Download
M xfa/fde/css/fde_csscache.h View 3 chunks +8 lines, -5 lines 0 comments Download
M xfa/fde/css/fde_csscache.cpp View 1 3 chunks +21 lines, -14 lines 0 comments Download
M xfa/fde/css/fde_cssstyleselector.h View 2 chunks +3 lines, -2 lines 0 comments Download
M xfa/fde/css/fde_cssstyleselector.cpp View 4 chunks +36 lines, -28 lines 0 comments Download
M xfa/fxfa/app/xfa_textlayout.h View 2 chunks +17 lines, -12 lines 0 comments Download
M xfa/fxfa/app/xfa_textlayout.cpp View 1 chunk +2 lines, -31 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
dsinclair
PTAL. My understanding is CFX_WideString is copy-on-write. So, I shouldn't be copying the strings just ...
4 years, 8 months ago (2016-04-21 20:10:52 UTC) #2
Tom Sepez
lgtm https://codereview.chromium.org/1911843002/diff/1/xfa/fde/css/fde_csscache.cpp File xfa/fde/css/fde_csscache.cpp (right): https://codereview.chromium.org/1911843002/diff/1/xfa/fde/css/fde_csscache.cpp#newcode32 xfa/fde/css/fde_csscache.cpp:32: FXSYS_assert(pTag); not needed, given line 38
4 years, 8 months ago (2016-04-21 20:21:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1911843002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1911843002/20001
4 years, 8 months ago (2016-04-21 20:23:17 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://pdfium.googlesource.com/pdfium/+/bc1cbabe8d8bfa74d25160c14afa30d5b40df335
4 years, 8 months ago (2016-04-21 20:37:14 UTC) #8
dsinclair
4 years, 8 months ago (2016-04-21 20:46:34 UTC) #9
Message was sent while issue was closed.
https://codereview.chromium.org/1911843002/diff/1/xfa/fde/css/fde_csscache.cpp
File xfa/fde/css/fde_csscache.cpp (right):

https://codereview.chromium.org/1911843002/diff/1/xfa/fde/css/fde_csscache.cp...
xfa/fde/css/fde_csscache.cpp:32: FXSYS_assert(pTag);
On 2016/04/21 20:21:56, Tom Sepez wrote:
> not needed, given line 38

Done.

Powered by Google App Engine
This is Rietveld 408576698