third_party/libaddressinput/chromium/storage_test_runner.cc - Issue 1911823002: Convert //third_party from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/libaddressinput/chromium/storage_test_runner.cc

Issue 1911823002: Convert //third_party from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update crashpad's README.chromium Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/libaddressinput/chromium/storage_test_runner.h ('k') | third_party/libaddressinput/chromium/string_compare.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/libaddressinput/chromium/storage_test_runner.cc

diff --git a/third_party/libaddressinput/chromium/storage_test_runner.cc b/third_party/libaddressinput/chromium/storage_test_runner.cc

index 453f0f292895382f94d166a35aea210b17e2b160..67e4b244fd4376fd04391f23f5d211190c7eadd2 100644

--- a/third_party/libaddressinput/chromium/storage_test_runner.cc

+++ b/third_party/libaddressinput/chromium/storage_test_runner.cc

@@ -35,8 +35,8 @@ void StorageTestRunner::ClearValues() {

data_.clear();

}

-scoped_ptr<Storage::Callback> StorageTestRunner::BuildCallback() {

- return scoped_ptr<Storage::Callback>(::i18n::addressinput::BuildCallback(

+std::unique_ptr<Storage::Callback> StorageTestRunner::BuildCallback() {

+ return std::unique_ptr<Storage::Callback>(::i18n::addressinput::BuildCallback(

this, &StorageTestRunner::OnDataReady));

}

@@ -54,7 +54,7 @@ void StorageTestRunner::OnDataReady(bool success,

void StorageTestRunner::GetWithoutPutReturnsEmptyData() {

ClearValues();

- scoped_ptr<Storage::Callback> callback(BuildCallback());

+ std::unique_ptr<Storage::Callback> callback(BuildCallback());

storage_->Get("key", *callback);

EXPECT_FALSE(success_);

@@ -65,7 +65,7 @@ void StorageTestRunner::GetWithoutPutReturnsEmptyData() {

void StorageTestRunner::GetReturnsWhatWasPut() {

ClearValues();

storage_->Put("key", new std::string("value"));

- scoped_ptr<Storage::Callback> callback(BuildCallback());

+ std::unique_ptr<Storage::Callback> callback(BuildCallback());

storage_->Get("key", *callback);

EXPECT_TRUE(success_);

@@ -77,7 +77,7 @@ void StorageTestRunner::SecondPutOverwritesData() {

ClearValues();

storage_->Put("key", new std::string("bad-value"));

storage_->Put("key", new std::string("good-value"));

- scoped_ptr<Storage::Callback> callback(BuildCallback());

+ std::unique_ptr<Storage::Callback> callback(BuildCallback());

storage_->Get("key", *callback);

EXPECT_TRUE(success_);