third_party/libaddressinput/chromium/chrome_metadata_source_unittest.cc - Issue 1911823002: Convert //third_party from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/libaddressinput/chromium/chrome_metadata_source_unittest.cc

Issue 1911823002: Convert //third_party from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update crashpad's README.chromium Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/libaddressinput/chromium/chrome_metadata_source.cc ('k') | third_party/libaddressinput/chromium/chrome_storage_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/libaddressinput/chromium/chrome_metadata_source_unittest.cc

diff --git a/third_party/libaddressinput/chromium/chrome_metadata_source_unittest.cc b/third_party/libaddressinput/chromium/chrome_metadata_source_unittest.cc

index ae92a76654b5c406ef94440aa156c7788fc40744..55d723bbc695dea3def87e3e3ca2a63a46255598 100644

--- a/third_party/libaddressinput/chromium/chrome_metadata_source_unittest.cc

+++ b/third_party/libaddressinput/chromium/chrome_metadata_source_unittest.cc

@@ -36,9 +36,9 @@ class ChromeMetadataSourceTest : public testing::Test {

new net::TestURLRequestContextGetter(

base::ThreadTaskRunnerHandle::Get()));

ChromeMetadataSource impl(std::string(), getter.get());

- scoped_ptr< ::i18n::addressinput::Source::Callback> callback(

+ std::unique_ptr<::i18n::addressinput::Source::Callback> callback(

::i18n::addressinput::BuildCallback(

- this, &ChromeMetadataSourceTest::OnDownloaded));

+ this, &ChromeMetadataSourceTest::OnDownloaded));

impl.Get(url_.spec(), *callback);

base::MessageLoop::current()->RunUntilIdle();

}

@@ -66,7 +66,7 @@ class ChromeMetadataSourceTest : public testing::Test {

net::URLFetcherImplFactory factory_;

net::FakeURLFetcherFactory fake_factory_;

GURL url_;

- scoped_ptr<std::string> data_;

+ std::unique_ptr<std::string> data_;

bool success_;

};