Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: third_party/crashpad/crashpad/snapshot/win/process_snapshot_win.cc

Issue 1911823002: Convert //third_party from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: cacheinvalidation Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/crashpad/crashpad/snapshot/win/process_snapshot_win.cc
diff --git a/third_party/crashpad/crashpad/snapshot/win/process_snapshot_win.cc b/third_party/crashpad/crashpad/snapshot/win/process_snapshot_win.cc
index 41c390275da3cc58fcd76b6ba811d7a77ab92d44..173b1b198756f6659a6aecf5eb25641e808c698e 100644
--- a/third_party/crashpad/crashpad/snapshot/win/process_snapshot_win.cc
+++ b/third_party/crashpad/crashpad/snapshot/win/process_snapshot_win.cc
@@ -12,15 +12,15 @@
// See the License for the specific language governing permissions and
// limitations under the License.
-#include "snapshot/win/process_snapshot_win.h"
Robert Sesek 2016/04/21 19:45:30 Don't think this is right.
dcheng 2016/04/21 20:11:00 Done.
-
#include <algorithm>
#include "base/logging.h"
+#include "base/memory/ptr_util.h"
#include "base/strings/stringprintf.h"
#include "base/strings/utf_string_conversions.h"
#include "snapshot/win/memory_snapshot_win.h"
#include "snapshot/win/module_snapshot_win.h"
+#include "snapshot/win/process_snapshot_win.h"
#include "util/win/nt_internals.h"
#include "util/win/registration_protocol_win.h"
#include "util/win/time.h"
@@ -235,7 +235,7 @@ void ProcessSnapshotWin::InitializeThreads(
process_reader_.Threads();
for (const ProcessReaderWin::Thread& process_reader_thread :
process_reader_threads) {
- auto thread = make_scoped_ptr(new internal::ThreadSnapshotWin());
+ auto thread = base::WrapUnique(new internal::ThreadSnapshotWin());
if (thread->Initialize(&process_reader_,
process_reader_thread,
gather_indirectly_referenced_memory)) {
@@ -249,7 +249,7 @@ void ProcessSnapshotWin::InitializeModules() {
process_reader_.Modules();
for (const ProcessInfo::Module& process_reader_module :
process_reader_modules) {
- auto module = make_scoped_ptr(new internal::ModuleSnapshotWin());
+ auto module = base::WrapUnique(new internal::ModuleSnapshotWin());
if (module->Initialize(&process_reader_, process_reader_module)) {
modules_.push_back(module.release());
}

Powered by Google App Engine
This is Rietveld 408576698