drawImage throw when ImageBitmap is neutered

drawImage throw when ImageBitmap is neutered

When the source of canvas.drawImage() is an ImageBitmap and it has been
neutered, we should throw an InvalidStateError.

BUG=605606
Committed: https://crrev.com/ee0c958459d7a6307735cdecaaabd64fa40c7b88
Cr-Commit-Position: refs/heads/master@{#389496}

[xidachen, 2016-04-21 18:43:21]

Description was changed from

==========
drawImage throw when ImageBitmap is neutered

When the source of canvas.drawImage() is an ImageBitmap and it has been
neutered, we should throw an error.

BUG=605606
==========

to

==========
drawImage throw when ImageBitmap is neutered

When the source of canvas.drawImage() is an ImageBitmap and it has been
neutered, we should throw an InvalidStateError.

BUG=605606
==========

[xidachen, 2016-04-21 18:43:22]

xidachen@chromium.org changed reviewers:
+ junov@chromium.org

[Justin Novosad, 2016-04-21 20:45:19]

https://codereview.chromium.org/1911793003/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/canvas/canvas-ImageBitmap-close.html
(right):

https://codereview.chromium.org/1911793003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/canvas-ImageBitmap-close.html:32: try
{
In tests that include js-test.js, you might as well use "shouldThrow()"

https://codereview.chromium.org/1911793003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp
(right):

https://codereview.chromium.org/1911793003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp:856:
static bool imageSourceNeutered(CanvasImageSource* imageSource, ExceptionState&
exceptionState)
I think you should put this inside toImageSourceInternal, make that function
throw and return NULL if neutered.

https://codereview.chromium.org/1911793003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp:1103:
CanvasImageSource* imageSourceInternal = toImageSourceInternal(imageSource);
You forgot about this guy.

[xidachen, 2016-04-22 01:58:13]

https://codereview.chromium.org/1911793003/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/canvas/canvas-ImageBitmap-close.html
(right):

https://codereview.chromium.org/1911793003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/canvas-ImageBitmap-close.html:32: try
{
On 2016/04/21 20:45:19, Justin Novosad wrote:
> In tests that include js-test.js, you might as well use "shouldThrow()"

Done.

https://codereview.chromium.org/1911793003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp
(right):

https://codereview.chromium.org/1911793003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp:856:
static bool imageSourceNeutered(CanvasImageSource* imageSource, ExceptionState&
exceptionState)
On 2016/04/21 20:45:19, Justin Novosad wrote:
> I think you should put this inside toImageSourceInternal, make that function
> throw and return NULL if neutered.

Done.

https://codereview.chromium.org/1911793003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp:1103:
CanvasImageSource* imageSourceInternal = toImageSourceInternal(imageSource);
On 2016/04/21 20:45:19, Justin Novosad wrote:
> You forgot about this guy.

Done.

[xidachen, 2016-04-25 15:23:41]

gentle ping.

[Justin Novosad, 2016-04-25 15:29:41]

On 2016/04/25 15:23:41, xidachen wrote:
> gentle ping.

lgtm

[xidachen, 2016-04-25 15:30:01]

The CQ bit was checked by xidachen@chromium.org

[commit-bot: I haz the power, 2016-04-25 15:30:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1911793003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1911793003/40001

[commit-bot: I haz the power, 2016-04-25 15:39:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-25 15:39:02]

Try jobs failed on following builders:
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[xidachen, 2016-04-25 15:50:56]

The CQ bit was checked by xidachen@chromium.org

[commit-bot: I haz the power, 2016-04-25 15:51:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1911793003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1911793003/40001

[commit-bot: I haz the power, 2016-04-25 16:43:46]

Description was changed from

==========
drawImage throw when ImageBitmap is neutered

When the source of canvas.drawImage() is an ImageBitmap and it has been
neutered, we should throw an InvalidStateError.

BUG=605606
==========

to

==========
drawImage throw when ImageBitmap is neutered

When the source of canvas.drawImage() is an ImageBitmap and it has been
neutered, we should throw an InvalidStateError.

BUG=605606
==========

[commit-bot: I haz the power, 2016-04-25 16:43:47]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-25 16:45:31]

Description was changed from

==========
drawImage throw when ImageBitmap is neutered

When the source of canvas.drawImage() is an ImageBitmap and it has been
neutered, we should throw an InvalidStateError.

BUG=605606
==========

to

==========
drawImage throw when ImageBitmap is neutered

When the source of canvas.drawImage() is an ImageBitmap and it has been
neutered, we should throw an InvalidStateError.

BUG=605606

Committed: https://crrev.com/ee0c958459d7a6307735cdecaaabd64fa40c7b88
Cr-Commit-Position: refs/heads/master@{#389496}
==========

[commit-bot: I haz the power, 2016-04-25 16:45:32]

Patchset 3 (id:??) landed as
https://crrev.com/ee0c958459d7a6307735cdecaaabd64fa40c7b88
Cr-Commit-Position: refs/heads/master@{#389496}