Issue 1911773002: Clean up logic to determine if a navigation is from GWS.

Issue 1911773002: Clean up logic to determine if a navigation is from GWS. (Closed)

Created:
4 years, 8 months ago by Charlie Harrison

Modified:
4 years, 8 months ago

Reviewers:
Bryan McQuade

CC:
chromium-reviews, asvitkine+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2704

Target Ref:
refs/pending/branch-heads/2704

Project:
chromium

Visibility:
Public.

Clean up logic to determine if a navigation is from GWS. This change updates the FromGWS metric logger to implement the logic described in https://docs.google.com/document/d/1jNPZ6Aeh0KV6umw1yZrrkfXRfxWNruwu7FELLx_cpOg/edit BUG=604418 Review URL: https://codereview.chromium.org/1891883002 TBR=bmcquade@chromium.org Cr-Commit-Position: refs/heads/master@{#388396} (cherry picked from commit 5ff8031245ce89165de8b803eb671b719b9657ca) Committed: https://chromium.googlesource.com/chromium/src/+/032da1acc611d4eea3cb73423b620305869cbaac

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+762 lines, -176 lines)			Patch
M	chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h	View	1 chunk	+72 lines, -6 lines	0 comments	Download
M	chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc	View	2 chunks	+216 lines, -74 lines	0 comments	Download
M	chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer_unittest.cc	View	1 chunk	+467 lines, -96 lines	0 comments	Download
M	tools/metrics/histograms/histograms.xml	View	1 chunk	+7 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

Charlie Harrison

4 years, 8 months ago (2016-04-21 13:44:29 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
032da1acc611d4eea3cb73423b620305869cbaac (presubmit successful).