Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 191173002: Fix typo in ExtensionHost (Closed)

Created:
6 years, 9 months ago by James Cook
Modified:
6 years, 9 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, kirr
Visibility:
Public.

Description

Fix typo in ExtensionHost A backwards conditional could, in theory, result in dev tools not being able to attach to extension background pages. I cannot reproduce a problem with this but the code is clearly wrong. BUG=none TEST=none (QA - nothing to do here) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255852

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/extensions/extension_host.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (0 generated)
James Cook
yoz, PTAL I looked into writing a test for this but it's a tremendous amount ...
6 years, 9 months ago (2014-03-07 17:35:28 UTC) #1
James Cook
kirr@yandex-team.ru FYI -- thanks for finding this!
6 years, 9 months ago (2014-03-07 17:36:38 UTC) #2
Yoyo Zhou
LGTM
6 years, 9 months ago (2014-03-07 18:50:49 UTC) #3
James Cook
The CQ bit was checked by jamescook@chromium.org
6 years, 9 months ago (2014-03-07 19:08:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/191173002/1
6 years, 9 months ago (2014-03-07 19:09:28 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-07 19:14:02 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg
6 years, 9 months ago (2014-03-07 19:14:03 UTC) #7
James Cook
The CQ bit was checked by jamescook@chromium.org
6 years, 9 months ago (2014-03-07 19:17:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/191173002/1
6 years, 9 months ago (2014-03-07 19:19:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/191173002/1
6 years, 9 months ago (2014-03-07 20:25:42 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/191173002/1
6 years, 9 months ago (2014-03-08 10:52:13 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-08 14:22:17 UTC) #12
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) telemetry_perf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=234354
6 years, 9 months ago (2014-03-08 14:22:18 UTC) #13
James Cook
The CQ bit was checked by jamescook@chromium.org
6 years, 9 months ago (2014-03-09 15:35:29 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/191173002/1
6 years, 9 months ago (2014-03-09 15:35:35 UTC) #15
commit-bot: I haz the power
6 years, 9 months ago (2014-03-09 16:17:38 UTC) #16
Message was sent while issue was closed.
Change committed as 255852

Powered by Google App Engine
This is Rietveld 408576698