Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 1911713002: Subzero: Fix a warning message in the browser build. (Closed)

Created:
4 years, 8 months ago by Jim Stichnoth
Modified:
4 years, 8 months ago
Reviewers:
Eric Holk, Karl, sehr, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: Fix a warning message in the browser build. Due to a mistake in the logic in https://codereview.chromium.org/1903553004 , a warning is printed even when LogFilename is properly set to "-". BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4370 R=jpp@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=64045042b801685e6e4f25613eada86ee2f7d71a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M src/IceBrowserCompileServer.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Jim Stichnoth
4 years, 8 months ago (2016-04-21 06:53:52 UTC) #3
John
lgtm
4 years, 8 months ago (2016-04-21 12:24:32 UTC) #4
Jim Stichnoth
4 years, 8 months ago (2016-04-21 12:38:53 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
64045042b801685e6e4f25613eada86ee2f7d71a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698