Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1260)

Unified Diff: scripts/common/chromium_utils.py

Issue 1911673003: Add more tracing prints to ProcessRead() function. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/common/chromium_utils.py
diff --git a/scripts/common/chromium_utils.py b/scripts/common/chromium_utils.py
index a309e61e689a9517f2390654937191d22ef26f39..670bd0db103e2a7bb293b7ab7185f3d0de1ac97b 100644
--- a/scripts/common/chromium_utils.py
+++ b/scripts/common/chromium_utils.py
@@ -926,6 +926,7 @@ def RunCommand(command, parser_func=None, filter_obj=None, pipes=None,
# Wait for kill signal or timeout.
if kill_event.wait(timeout):
break
+ print threading.currentThread(), 'TimedFlush: Finished'
# TODO(all): nsylvain's CommandRunner in buildbot_slave is based on this
# method. Update it when changes are introduced here.
@@ -967,6 +968,8 @@ def RunCommand(command, parser_func=None, filter_obj=None, pipes=None,
in_line = cStringIO.StringIO()
in_byte = readfh.read(1)
+ print threading.currentThread(), 'ProcessRead: readfh finished.'
+
if log_event and in_line.getvalue():
log_event.set()
@@ -983,9 +986,11 @@ def RunCommand(command, parser_func=None, filter_obj=None, pipes=None,
if in_line.getvalue():
writefh.write(in_line.getvalue())
finally:
+ print threading.currentThread(), 'ProcessRead: cleaning up.'
kill_event.set()
flush_thread.join()
writefh.flush()
+ print threading.currentThread(), 'ProcessRead: finished.'
pipes = pipes or []
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698