Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 1911673002: Remove CFX_ArrayTemplate from fpdf_parser_decode.cpp (Closed)

Created:
4 years, 8 months ago by Tom Sepez
Modified:
4 years, 8 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove CFX_ArrayTemplate from fpdf_parser_decode.cpp Replace two parallel arrays with single array of pairs. Committed: https://pdfium.googlesource.com/pdfium/+/ca612c1f9c47fae74dda493291d52ec27eff4a7b

Patch Set 1 #

Patch Set 2 : IWYU for std::pair. #

Total comments: 2

Patch Set 3 : tidy #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -14 lines) Patch
M core/fpdfapi/fpdf_parser/fpdf_parser_decode.cpp View 1 2 2 chunks +12 lines, -14 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Tom Sepez
Lei, for review.
4 years, 8 months ago (2016-04-21 00:07:47 UTC) #3
Lei Zhang
lgtm https://codereview.chromium.org/1911673002/diff/20001/core/fpdfapi/fpdf_parser/fpdf_parser_decode.cpp File core/fpdfapi/fpdf_parser/fpdf_parser_decode.cpp (right): https://codereview.chromium.org/1911673002/diff/20001/core/fpdfapi/fpdf_parser/fpdf_parser_decode.cpp#newcode355 core/fpdfapi/fpdf_parser/fpdf_parser_decode.cpp:355: pParams ? pParamsArray->GetDictAt(i) : nullptr}); Use |pParamsArray| instead ...
4 years, 8 months ago (2016-04-21 00:51:58 UTC) #4
Tom Sepez
https://codereview.chromium.org/1911673002/diff/20001/core/fpdfapi/fpdf_parser/fpdf_parser_decode.cpp File core/fpdfapi/fpdf_parser/fpdf_parser_decode.cpp (right): https://codereview.chromium.org/1911673002/diff/20001/core/fpdfapi/fpdf_parser/fpdf_parser_decode.cpp#newcode355 core/fpdfapi/fpdf_parser/fpdf_parser_decode.cpp:355: pParams ? pParamsArray->GetDictAt(i) : nullptr}); On 2016/04/21 00:51:58, Lei ...
4 years, 8 months ago (2016-04-21 17:48:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1911673002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1911673002/40001
4 years, 8 months ago (2016-04-21 17:49:02 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-21 18:28:07 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/ca612c1f9c47fae74dda493291d52ec27eff...

Powered by Google App Engine
This is Rietveld 408576698