base/trace_event/trace_config_unittest.cc - Issue 1911643002: Add configurable limit to allocations in heap profiler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/trace_event/trace_config_unittest.cc

Issue 1911643002: Add configurable limit to allocations in heap profiler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing comments Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/trace_event/trace_config.h ('K') | « base/trace_event/trace_config.cc ('k') | content/browser/devtools/protocol/tracing_handler_unittest.cc » ('j') | third_party/WebKit/Source/devtools/protocol.json » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: base/trace_event/trace_config_unittest.cc

diff --git a/base/trace_event/trace_config_unittest.cc b/base/trace_event/trace_config_unittest.cc

index 1fb41f86fb9eef43d13ac122c7bff135ac8d3e04..fc445aa75fd4421354b9d3ca8f7a450e56d2876e 100644

--- a/base/trace_event/trace_config_unittest.cc

+++ b/base/trace_event/trace_config_unittest.cc

@@ -36,6 +36,7 @@ const char kCustomTraceConfigString[] =

"\"disabled-by-default-cc\","

"\"disabled-by-default-memory-infra\"],"

"\"memory_dump_config\":{"

+ "\"min_allocation_size_bytes\":10240,"

"\"triggers\":["

"{\"mode\":\"light\",\"periodic_interval_ms\":50},"

"{\"mode\":\"detailed\",\"periodic_interval_ms\":1000}"

@@ -318,6 +319,7 @@ TEST(TraceConfigTest, TraceConfigFromDict) {

EXPECT_TRUE(custom_tc.IsSamplingEnabled());

EXPECT_TRUE(custom_tc.IsSystraceEnabled());

EXPECT_TRUE(custom_tc.IsArgumentFilterEnabled());

+ EXPECT_EQ(10240u, custom_tc.GetMinAllocationSizeBytes());

EXPECT_STREQ("included,inc_pattern*,"

"disabled-by-default-cc,disabled-by-default-memory-infra,"

"-excluded,-exc_pattern*,"