Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Unified Diff: third_party/WebKit/Source/devtools/protocol.json

Issue 1911643002: Add configurable limit to allocations in heap profiler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update rename in unittest Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/protocol.json
diff --git a/third_party/WebKit/Source/devtools/protocol.json b/third_party/WebKit/Source/devtools/protocol.json
index 90447fb66596ce7c837426bcd52e1e74ff36e3d7..438a84aebc4b99ff35b0176a1c80d120c69d786c 100644
--- a/third_party/WebKit/Source/devtools/protocol.json
+++ b/third_party/WebKit/Source/devtools/protocol.json
@@ -4693,7 +4693,7 @@
"domain": "Tracing",
"types": [
{
- "id": "MemoryDumpTrigger",
+ "id": "Trigger",
"type": "object",
"properties": [
{ "name": "mode", "type": "string", "enum": ["light", "detailed"], "description": "Level of detail of the triggered memory dumps." },
@@ -4701,11 +4701,19 @@
],
"description": "Memory dump trigger configuration."
},
+ { "id": "HeapProfiler",
pfeldman 2016/04/29 02:14:27 This is getting too hairy. Could we bring some san
Primiano Tucci (use gerrit) 2016/04/29 08:54:00 Can we delay the exposure of this to the devtools
+ "type": "object",
+ "properties": [
+ { "name": "breakdownThresholdBytes", "type": "number", "optional": true, "description": "The threshold in bytes beneath which heap profiler stacks are not broken down any further" }
+ ],
+ "description": "Provides additional options for the heap profiler."
+ },
{
"id": "MemoryDumpConfig",
"type": "object",
"properties": [
- { "name": "triggers", "type": "array", "items": { "$ref": "MemoryDumpTrigger" }, "optional": false, "description": "Memory dump trigger configuration." }
+ { "name": "triggers", "type": "array", "items": { "$ref": "Trigger" }, "optional": false, "description": "Memory dump trigger configuration." },
+ { "name": "heapProfilerOptions", "$ref": "HeapProfiler", "optional": true, "description": "Provides additional options for the heap profiler." }
],
"description": "Configuration for memory dump triggers. Used only when \"memory-infra\" category is enabled."
},

Powered by Google App Engine
This is Rietveld 408576698