Add configurable limit to allocations in heap profiler.

base/trace_event/heap_profiler_heap_dump_writer_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/trace_event/heap_profiler_heap_dump_writer.h"
 
 #include <stddef.h>
 
 #include <memory>
 #include <set>
 #include <string>
 
 #include "base/json/json_reader.h"
 #include "base/macros.h"
 #include "base/memory/ptr_util.h"
 #include "base/trace_event/heap_profiler_allocation_context.h"
 #include "base/trace_event/heap_profiler_stack_frame_deduplicator.h"
 #include "base/trace_event/heap_profiler_type_name_deduplicator.h"
+#include "base/trace_event/memory_dump_session_state.h"
 #include "base/trace_event/trace_event_argument.h"
 #include "base/values.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace {
 
 // Define all strings once, because the deduplicator requires pointer equality,
 // and string interning is unreliable.
 const char kBrowserMain[] = "BrowserMain";
 const char kRendererMain[] = "RendererMain";
@@ skipping 177 matching lines @@
   //
   // |        | CrWidget <- BrMain | Init <- RenMain |     Sum     |
   // +--------+--------------------+-----------------+-------------+
   // |        |       size   count |   size    count | size  count |
   // | int    |         10       5 |      0        0 |   10      5 |
   // | bool   |         18      18 |     30       30 |   48     48 |
   // | string |          0       0 |     19        4 |   19      4 |
   // +--------+--------------------+-----------------+-------------+
   // | Sum    |         28      23 |     49      34  |   77     57 |
 
-  auto sf_deduplicator = WrapUnique(new StackFrameDeduplicator);
-  auto tn_deduplicator = WrapUnique(new TypeNameDeduplicator);
-  HeapDumpWriter writer(sf_deduplicator.get(), tn_deduplicator.get());
+  auto session = new MemoryDumpSessionState();

[Primiano Tucci (use gerrit), 2016/04/22 14:18:28]

This is leaking the SessionState now, there is no delete.
I guess here you want:
unique_ptr<MemoryDumpSessionState> session(new MemoryDumpSessionState())

[Maria, 2016/04/25 18:37:23]

Acknowledged.

+  session->SetStackFrameDeduplicator(WrapUnique(new StackFrameDeduplicator));
+  session->SetTypeNameDeduplicator(WrapUnique(new TypeNameDeduplicator));
+  HeapDumpWriter writer(*session);

[Primiano Tucci (use gerrit), 2016/04/22 14:18:29]

anyways, following my suggestions above, since this is testing the internal
class, there is no need to change this.

[Maria, 2016/04/25 18:37:23]

Done.

   const std::set<Entry>& dump = writer.Summarize(metrics_by_context);
 
   // Get the indices of the backtraces and types by adding them again to the
   // deduplicator. Because they were added before, the same number is returned.
   StackFrame bt0[] = {kRendererMain, kInitialize};
   StackFrame bt1[] = {kBrowserMain, kCreateWidget};
-  int bt_renderer_main = sf_deduplicator->Insert(bt0, bt0 + 1);
-  int bt_browser_main = sf_deduplicator->Insert(bt1, bt1 + 1);
-  int bt_renderer_main_initialize = sf_deduplicator->Insert(bt0, bt0 + 2);
-  int bt_browser_main_create_widget = sf_deduplicator->Insert(bt1, bt1 + 2);
-  int type_id_int = tn_deduplicator->Insert(kInt);
-  int type_id_bool = tn_deduplicator->Insert(kBool);
-  int type_id_string = tn_deduplicator->Insert(kString);
+  int bt_renderer_main = session->stack_frame_deduplicator()->Insert(bt0, bt0 + 1);
+  int bt_browser_main = session->stack_frame_deduplicator()->Insert(bt1, bt1 + 1);
+  int bt_renderer_main_initialize = session->stack_frame_deduplicator()->Insert(bt0, bt0 + 2);
+  int bt_browser_main_create_widget = session->stack_frame_deduplicator()->Insert(bt1, bt1 + 2);
+  int type_id_int = session->type_name_deduplicator()->Insert(kInt);
+  int type_id_bool = session->type_name_deduplicator()->Insert(kBool);
+  int type_id_string = session->type_name_deduplicator()->Insert(kString);
 
   // Full heap should have size 77.
   AssertSizeAndCountEq(dump, -1, -1, {77, 57});
 
   // 49 bytes in 34 chunks were allocated in RendererMain and children. Also
   // check the type breakdown.
   AssertSizeAndCountEq(dump, bt_renderer_main, -1, {49, 34});
   AssertSizeAndCountEq(dump, bt_renderer_main, type_id_bool, {30, 30});
   AssertSizeAndCountEq(dump, bt_renderer_main, type_id_string, {19, 4});
 
@@ skipping 33 matching lines @@
   metrics_by_context[ctx] = {512, 1};
 
   // 1 MiB and 1 chunk in BrowserMain -> CreateWidget -> GetBitmap.
   ctx.backtrace.frames[2] = kGetBitmap;
   metrics_by_context[ctx] = {1024 * 1024, 1};
 
   // 0.5 KiB and 1 chunk in BrowserMain -> CreateWidget -> Initialize.
   ctx.backtrace.frames[2] = kInitialize;
   metrics_by_context[ctx] = {512, 1};
 
-  auto sf_deduplicator = WrapUnique(new StackFrameDeduplicator);
-  auto tn_deduplicator = WrapUnique(new TypeNameDeduplicator);
-  HeapDumpWriter writer(sf_deduplicator.get(), tn_deduplicator.get());
+  auto session = new MemoryDumpSessionState();

[Primiano Tucci (use gerrit), 2016/04/22 14:18:29]

ditto about leaking, and ditto about might not be needed

[Maria, 2016/04/25 18:37:23]

Acknowledged.

+  session->SetStackFrameDeduplicator(WrapUnique(new StackFrameDeduplicator));
+  session->SetTypeNameDeduplicator(WrapUnique(new TypeNameDeduplicator));
+  HeapDumpWriter writer(*session);
   const std::set<Entry>& dump = writer.Summarize(metrics_by_context);
 
   // Get the indices of the backtraces and types by adding them again to the
   // deduplicator. Because they were added before, the same number is returned.
   StackFrame bt0[] = {kBrowserMain, kCreateWidget, kGetBitmap};
   StackFrame bt1[] = {kBrowserMain, kCreateWidget, kInitialize};
-  int bt_browser_main = sf_deduplicator->Insert(bt0, bt0 + 1);
-  int bt_create_widget = sf_deduplicator->Insert(bt0, bt0 + 2);
-  int bt_get_bitmap = sf_deduplicator->Insert(bt0, bt0 + 3);
-  int bt_initialize = sf_deduplicator->Insert(bt1, bt1 + 3);
+  int bt_browser_main = session->stack_frame_deduplicator()->Insert(bt0, bt0 + 1);
+  int bt_create_widget = session->stack_frame_deduplicator()->Insert(bt0, bt0 + 2);
+  int bt_get_bitmap = session->stack_frame_deduplicator()->Insert(bt0, bt0 + 3);
+  int bt_initialize = session->stack_frame_deduplicator()->Insert(bt1, bt1 + 3);
 
   // Full heap should have size of 1 MiB + 1 KiB and 3 chunks.
   AssertSizeAndCountEq(dump, -1, -1 /* No type specified */,
                        {1024 * 1024 + 512 + 512, 3});
 
   // |GetBitmap| allocated 1 MiB and 1 chunk.
   AssertSizeAndCountEq(dump, bt_get_bitmap, -1, {1024 * 1024, 1});
 
   // Because |GetBitmap| was dumped, all of its parent nodes should have been
   // dumped too. |CreateWidget| has 1 MiB in |GetBitmap|, 512 bytes in
   // |Initialize|, and 512 bytes of its own and each in 1 chunk.
   AssertSizeAndCountEq(dump, bt_create_widget, -1,
                        {1024 * 1024 + 512 + 512, 3});
   AssertSizeAndCountEq(dump, bt_browser_main, -1, {1024 * 1024 + 512 + 512, 3});
 
   // Initialize was not significant, it should not have been dumped.
   AssertNotDumped(dump, bt_initialize, -1);
 }
 
 }  // namespace internal
 }  // namespace trace_event
 }  // namespace base