Add configurable limit to allocations in heap profiler.

base/trace_event/trace_config.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_TRACE_EVENT_TRACE_CONFIG_H_
 #define BASE_TRACE_EVENT_TRACE_CONFIG_H_
 
 #include <stdint.h>
 
 #include <string>
@@ skipping 29 matching lines @@
  public:
   typedef std::vector<std::string> StringList;
 
   // Specifies the memory dump config for tracing. Used only when
   // "memory-infra" category is enabled.
   struct MemoryDumpTriggerConfig {
     uint32_t periodic_interval_ms;
     MemoryDumpLevelOfDetail level_of_detail;
   };
 
   typedef std::vector<MemoryDumpTriggerConfig> MemoryDumpConfig;

[Primiano Tucci (use gerrit), 2016/04/21 16:53:22]

I think this is the culprit. Today 

typedef std::vector<MemoryDumpTriggerConfig> MemoryDumpConfig, which 
is essentially assuming MemoryDumpConfig contains only the list of triggers.
I think the way to go is making this like:

struct MemoryDumpConfig {
  std::vector<MemoryDumpTriggerConfig> triggers;
  HeapProfilerConfig heap_profiler_config;
}

where 
struct HeapProfilerConfig { 
  uint32_t breakdown_threshold_bytes;
}

does it make sense?

 
   TraceConfig();
 
   // Create TraceConfig object from category filter and trace options strings.
   //
   // |category_filter_string| is a comma-delimited list of category wildcards.
   // A category can have an optional '-' prefix to make it an excluded category.
   // All the same rules apply above, so for example, having both included and
   // excluded categories in the same list would not be supported.
   //
@@ skipping 79 matching lines @@
 
   TraceConfig& operator=(const TraceConfig& rhs);
 
   // Return a list of the synthetic delays specified in this category filter.
   const StringList& GetSyntheticDelayValues() const;
 
   TraceRecordMode GetTraceRecordMode() const { return record_mode_; }
   bool IsSamplingEnabled() const { return enable_sampling_; }
   bool IsSystraceEnabled() const { return enable_systrace_; }
   bool IsArgumentFilterEnabled() const { return enable_argument_filter_; }
+  size_t GetMinAllocationSizeBytes() const {

[Primiano Tucci (use gerrit), 2016/04/21 16:53:22]

I think this should be just part of MemoryDumpConfig (for which there is already
a getter below on line 178). No need to expose this here.

+    return min_allocation_size_bytes_;
+  }
 
   void SetTraceRecordMode(TraceRecordMode mode) { record_mode_ = mode; }
   void EnableSampling() { enable_sampling_ = true; }
   void EnableSystrace() { enable_systrace_ = true; }
   void EnableArgumentFilter() { enable_argument_filter_ = true; }
 
   // Writes the string representation of the TraceConfig. The string is JSON
   // formatted.
   std::string ToString() const;
 
@@ skipping 22 matching lines @@
                            TraceConfigFromInvalidLegacyStrings);
   FRIEND_TEST_ALL_PREFIXES(TraceConfigTest, ConstructDefaultTraceConfig);
   FRIEND_TEST_ALL_PREFIXES(TraceConfigTest, TraceConfigFromValidString);
   FRIEND_TEST_ALL_PREFIXES(TraceConfigTest, TraceConfigFromInvalidString);
   FRIEND_TEST_ALL_PREFIXES(TraceConfigTest,
                            IsEmptyOrContainsLeadingOrTrailingWhitespace);
   FRIEND_TEST_ALL_PREFIXES(TraceConfigTest, TraceConfigFromMemoryConfigString);
   FRIEND_TEST_ALL_PREFIXES(TraceConfigTest, LegacyStringToMemoryDumpConfig);
   FRIEND_TEST_ALL_PREFIXES(TraceConfigTest, EmptyMemoryDumpConfigTest);
 
+  // Default value for |min_allocation_size_bytes_|.
+  static const int kDefaultMinAllocationSizeBytes = 1024;
+
   // The default trace config, used when none is provided.
   // Allows all non-disabled-by-default categories through, except if they end
   // in the suffix 'Debug' or 'Test'.
   void InitializeDefault();
 
   // Initialize from a config dictionary.
   void InitializeFromConfigDict(const DictionaryValue& dict);
 
   // Initialize from a config string.
   void InitializeFromConfigString(const std::string& config_string);
@@ skipping 30 matching lines @@
       const std::string& str);
 
   bool HasIncludedPatterns() const;
 
   TraceRecordMode record_mode_;
   bool enable_sampling_ : 1;
   bool enable_systrace_ : 1;
   bool enable_argument_filter_ : 1;
 
   MemoryDumpConfig memory_dump_config_;
+  size_t min_allocation_size_bytes_;
 
   StringList included_categories_;
   StringList disabled_categories_;
   StringList excluded_categories_;
   StringList synthetic_delays_;
 };
 
 }  // namespace trace_event
 }  // namespace base
 
 #endif  // BASE_TRACE_EVENT_TRACE_CONFIG_H_