Add configurable limit to allocations in heap profiler.

base/trace_event/trace_config.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_TRACE_EVENT_TRACE_CONFIG_H_
 #define BASE_TRACE_EVENT_TRACE_CONFIG_H_
 
 #include <stdint.h>
 
 #include <string>
@@ skipping 22 matching lines @@
   RECORD_AS_MUCH_AS_POSSIBLE,
 
   // Echo to console. Events are discarded.
   ECHO_TO_CONSOLE,
 };
 
 class BASE_EXPORT TraceConfig {
  public:
   typedef std::vector<std::string> StringList;
 
-  // Specifies the memory dump config for tracing. Used only when
-  // "memory-infra" category is enabled.
-  struct MemoryDumpTriggerConfig {
-    uint32_t periodic_interval_ms;
-    MemoryDumpLevelOfDetail level_of_detail;
+  // Specifies the memory dump config for tracing.
+  // Used only when "memory-infra" category is enabled.
+  struct MemoryDumpConfig {
+    MemoryDumpConfig();
+    MemoryDumpConfig(const MemoryDumpConfig& other);
+    ~MemoryDumpConfig();
+
+    // Specifies the triggers in the memory dump config.
+    struct MemoryDumpTriggerConfig {

[Primiano Tucci (use gerrit), 2016/04/28 07:33:45]

I'd probably shorten these names (e.g. s/MemoryDumpTriggerConfig/Trigger/ and
s/HeapProfilerOptions/HeapProfiler/) and avoid the typedefs below, so you
directly use

MemoryDumpConfig::Trigger and MemoryDumpConfig::HeapProfiler in the .cc file.
typedef IMHO hurt a bit readability, as it force people do read the code to jump
through an extra hop.

[Maria, 2016/04/28 17:23:39]

Done.

+      uint32_t periodic_interval_ms;
+      MemoryDumpLevelOfDetail level_of_detail;
+    };
+
+    // Specifies the configuration options for the heap profiler.
+    struct HeapProfilerOptions {
+      // Default value for |breakdown_threshold_bytes|.
+      enum { kDefaultBreakdownThresholdBytes = 1024 };
+
+      HeapProfilerOptions();
+      ~HeapProfilerOptions();

[Primiano Tucci (use gerrit), 2016/04/28 07:33:45]

I think you can omit empty dtors for trivial structures like this. 

[Maria, 2016/04/28 17:23:39]

Done.

+
+      // Reset the options to default.
+      void Clear();
+
+      uint32_t breakdown_threshold_bytes;
+    };
+
+    // Reset the values in the config.
+    void Clear();
+
+    std::vector<MemoryDumpTriggerConfig> triggers;
+    HeapProfilerOptions heap_profiler_options;
   };
 
-  typedef std::vector<MemoryDumpTriggerConfig> MemoryDumpConfig;
+  typedef MemoryDumpConfig::MemoryDumpTriggerConfig MemoryDumpTrigger;
+  typedef MemoryDumpConfig::HeapProfilerOptions MemoryDumpHeapProfilerOptions;
 
   TraceConfig();
 
   // Create TraceConfig object from category filter and trace options strings.
   //
   // |category_filter_string| is a comma-delimited list of category wildcards.
   // A category can have an optional '-' prefix to make it an excluded category.
   // All the same rules apply above, so for example, having both included and
   // excluded categories in the same list would not be supported.
   //
@@ skipping 182 matching lines @@
   StringList included_categories_;
   StringList disabled_categories_;
   StringList excluded_categories_;
   StringList synthetic_delays_;
 };
 
 }  // namespace trace_event
 }  // namespace base
 
 #endif  // BASE_TRACE_EVENT_TRACE_CONFIG_H_