Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 1911633002: S390: [regexp] do not assume short external strings have a minimum size. (Closed)

Created:
4 years, 8 months ago by john.yan
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390: [regexp] do not assume short external strings have a minimum size. Port 3518e492c0939759ae1a2623bbd606646ee172f1 Original commit message: Short external strings do not cache the resource data, and may be used for compressible strings. The assumptions about their lengths is invalid and may lead to oob reads. R=yangguo@chromium.org, joransiu@ca.ibm.com, bjaideep@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG=v8:4923, chromium:604897 LOG=N Committed: https://crrev.com/14c9cbd4cfaa235801e0372178e8af039cb2233f Cr-Commit-Position: refs/heads/master@{#35682}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -39 lines) Patch
M src/s390/code-stubs-s390.cc View 4 chunks +29 lines, -39 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
john.yan
PTAL
4 years, 8 months ago (2016-04-20 21:56:03 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1911633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1911633002/1
4 years, 8 months ago (2016-04-20 21:56:22 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-20 22:13:35 UTC) #5
JoranSiu
lgtm
4 years, 8 months ago (2016-04-21 00:46:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1911633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1911633002/1
4 years, 8 months ago (2016-04-21 04:00:36 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-21 05:02:47 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:14:00 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/14c9cbd4cfaa235801e0372178e8af039cb2233f
Cr-Commit-Position: refs/heads/master@{#35682}

Powered by Google App Engine
This is Rietveld 408576698